Allow to run MP LRA TCK with externally managed coordinator #31944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xstefank
force-pushed
the
lra-coordinator-tck
branch
from
fd0bd02 to
85f794c
Compare
This comment has been minimized.
This comment has been minimized.
zhfeng
reviewed
Mar 20, 2023
| .withNetworkMode("host"); | ||
| if (System.getProperty("lra.coordinator.url") == null) { | ||
| LOGGER.debug("Starting LRA coordinator on port " + coordinatorPort); | ||
| coordinatorContainer = new GenericContainer<>(DockerImageName.parse("jbosstm/lra-coordinator:latest")) |
There was a problem hiding this comment.
The image name should be quay.io/jbosstm/lra-coordinator?
zhfeng
reviewed
Mar 20, 2023
| // lra-coordinator is a Quarkus service | ||
| .withEnv("QUARKUS_HTTP_PORT", String.valueOf(coordinatorPort)) | ||
| // need to run with host network because coordinator calls the TCK services from the container | ||
| .withNetworkMode("host"); |
There was a problem hiding this comment.
It could add waitingFor(Wait.forLogMessage(".*lra-coordinator-quarkus.*", 1)); to make sure the server is started.
|
This will need a rebase as I switched to the new quay.io images in another PR. |
gsmet
added
the
triage/needs-rebase
xstefank
force-pushed
the
lra-coordinator-tck
branch
from
85f794c to
e70e875
Compare
zhfeng
approved these changes
Mar 22, 2023
xstefank
force-pushed
the
lra-coordinator-tck
branch
from
e70e875 to
f7cdbcc
Compare
This comment has been minimized.
This comment has been minimized.
|
I'd ask for one last rebase as the PR is quite old |
xstefank
force-pushed
the
lra-coordinator-tck
branch
from
f7cdbcc to
2fa3fef
Compare
geoand
added
triage/waiting-for-ci
|
@geoand already rebased, just we might race-conditioned labels :) |
|
:) |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can reuse this back to back in the published coordinator image testing - https://github.com/jbosstm/lra-coordinator-quarkus