Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long deprecated jib property #31937

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 17, 2023

No description provided.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wonder if we could add an Openrewrite rule to migrate it

@geoand
Copy link
Contributor Author

geoand commented Mar 17, 2023

Good idea. Do we have any examples of rules that change properties?

@geoand
Copy link
Contributor Author

geoand commented Mar 17, 2023

Cool thanks

@geoand
Copy link
Contributor Author

geoand commented Mar 17, 2023

quarkusio/quarkus-updates#19 is the PR for updating the properties

geoand added a commit to geoand/quarkus-updates that referenced this pull request Mar 17, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 17, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit ba81297 into quarkusio:main Mar 17, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 17, 2023
@geoand geoand deleted the jib-deprecated-labels branch March 17, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants