Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of field lookupIfMissing in LookupUnlessProperty #31868

Merged

Conversation

jesantana
Copy link
Contributor

@jesantana jesantana commented Mar 15, 2023

Fixing javadoc of field lookupIfMissing in LookupUnlessProperty

Closes: #31863

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Mar 15, 2023
@geoand geoand requested a review from mkouba March 15, 2023 13:59
mkouba
mkouba previously approved these changes Mar 15, 2023
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I will need to look into the code because I'm not quite sure how this should work for LookupUnlessProperty.

@mkouba mkouba dismissed their stale review March 15, 2023 15:03

I need to check the code

@gsmet gsmet force-pushed the fix-documentation-lookupunlessproperty branch from ec81d7d to 7d0d4dc Compare March 15, 2023 17:27
@gsmet
Copy link
Member

gsmet commented Mar 15, 2023

I rebased to remove the merge commit.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 15, 2023

Failing Jobs - Building 7d0d4dc

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/resteasy-classic/rest-client/runtime 
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-http/http-event-server extensions/amazon-lambda-rest/deployment and 104 more

📦 extensions/resteasy-classic/rest-client/runtime

io.quarkus.restclient.runtime.RestClientBaseTest. - More details - Source on GitHub

java.io.IOException: Failed to delete temp directory D:\a\quarkus\quarkus\extensions\resteasy-classic\rest-client\runtime\target\junit8286209118024969923. The following paths could not be deleted (see suppressed exceptions for details): 
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350)
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251)

@geoand geoand merged commit 214bbc2 into quarkusio:main Mar 16, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property lookupIfMissing in LookupUnlessProperty has wrong documentation
4 participants