Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a warning during extension build if two sources of scm information disagree #31862

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

holly-cummins
Copy link
Contributor

This is a follow-up to #31747, which improves the logging.

  • Lower complaints about not resolving a local project to debug
  • Log a debug message if we can't find any scm information. I’ve done this at debug level, because it will show up in the local build for every extension generated using the template. It wouldn’t show in the CI builds, but people are most likely to pay attention to warnings in their local build, and then get stressed about them. We could require scm information as an input to the template, but that would worsen the getting started experience, and we don’t even need the information. We can increase the level if we’re seeing data completeness issues in extensions.
  • Log a warning if we have two sources (actions + pom) and they disagree

Example warning for conflict:

[INFO] --- quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (default) @ quarkus-pact-consumer ---
[WARNING] The scm-url coordinates in the build file, http://parent did not match the repository configured in the GITHUB_REPOSITORY environment variable, https://github.com/from/environment. The value which will be used for the extension metadata is https://github.com/from/environment.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform labels Mar 15, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 15, 2023

Failing Jobs - Building 358b38b

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 19 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/resteasy-classic/rest-client/runtime 
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-http/http-event-server extensions/amazon-lambda-rest/deployment and 104 more

📦 extensions/resteasy-classic/rest-client/runtime

io.quarkus.restclient.runtime.RestClientBaseTest. - More details - Source on GitHub

java.io.IOException: Failed to delete temp directory D:\a\quarkus\quarkus\extensions\resteasy-classic\rest-client\runtime\target\junit2976140413768363398. The following paths could not be deleted (see suppressed exceptions for details): 
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350)
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251)

⚙️ JVM Tests - JDK 19 #

- Failing: integration-tests/opentelemetry 

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet gsmet merged commit 44a2be0 into quarkusio:main Mar 16, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants