Container runtime detection cached in sys prop, container-docker extension #31857

Karm · 2023-03-15T10:08:29Z

~~Do not merge yet, ongoing testing on Windows Docker and Podman...~~

Followup on #31490

As per our discussion on Enable Podman and Docker Windows quarkus-container-image-docker testing #31490, the container runtime detected is cached in a sys prop, not in a file now.
Removed superfluous calls to podman when docker is hinted by quarkus.native.container-runtime and vice versa.
Fixed a scenario when there is neither podman nor docker and it's O.K. as it's not needed.
Switched extensions/container-image/container-image-docker to use Core's container runtime autodetection too, with the current property quarkus.docker.executable-name being an optional way to override the detection system.

The experience with extensions/container-image/container-image-docker is much improved on Podman only systems, because one doesn't have to explicitly specify quarkus.docker.executable-name=podman to make it work.

quarkus-bot · 2023-03-15T10:08:32Z

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

Karm · 2023-03-16T07:27:51Z

@geoand / @gsmet Could you help me with the CI pls? 🤔😔

geoand · 2023-03-16T07:28:51Z

I would rebase the PR onto main and force push. The problem was likely a GH Actions issue

…uation\nwhere there is no container runtime working and none is needed.

gsmet · 2023-03-16T13:26:01Z

@Karm I'm working on some additional cleanup on top of your patch. I would appreciate if you could review the changes once I push them.
(I'll add comments to explain the rationale of the changes)

gsmet

@Karm I added some comments to explain the logic of my changes.

Let me know if you're happy with them.

gsmet · 2023-03-16T13:27:07Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/AppCDSBuildStep.java

@@ -39,7 +39,6 @@ public class AppCDSBuildStep {
    public static final String CLASSES_LIST_FILE_NAME = "classes.lst";
    private static final String CONTAINER_IMAGE_BASE_BUILD_DIR = "/tmp/quarkus";
    private static final String CONTAINER_IMAGE_APPCDS_DIR = CONTAINER_IMAGE_BASE_BUILD_DIR + "/appcds";
-    public static final ContainerRuntimeUtil.ContainerRuntime CONTAINER_RUNTIME = detectContainerRuntime(false);


Let's avoid doing the autodetection in static fields.

gsmet · 2023-03-16T13:27:29Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/AppCDSBuildStep.java

-            throw new IllegalStateException("No container runtime was found. "
-                    + "Make sure you have either Docker or Podman installed in your environment.");
-        }
+        ContainerRuntime containerRuntime = detectContainerRuntime(true);


The exception will be thrown automatically if required is true.

gsmet · 2023-03-16T13:27:57Z

...yment/src/test/java/io/quarkus/deployment/pkg/steps/NativeImageBuildContainerRunnerTest.java

@@ -1,6 +1,5 @@
 package io.quarkus.deployment.pkg.steps;

-import static io.quarkus.deployment.pkg.steps.AppCDSBuildStep.CONTAINER_RUNTIME;


Let's not involved something that has nothing to do with this test.

gsmet · 2023-03-16T13:28:17Z

core/runtime/src/main/java/io/quarkus/runtime/util/ContainerRuntimeUtil.java

@@ -41,7 +41,7 @@ public static ContainerRuntime detectContainerRuntime() {
    }

    public static ContainerRuntime detectContainerRuntime(boolean required) {
-        final ContainerRuntime containerRuntime = loadConfig();
+        final ContainerRuntime containerRuntime = loadContainerRuntimeFromSystemProperty();


just a simple name change for clarity.

gsmet · 2023-03-16T13:29:42Z

core/runtime/src/main/java/io/quarkus/runtime/util/ContainerRuntimeUtil.java

-        } else if (ContainerRuntime.DOCKER.name().equalsIgnoreCase(runtime)) {
-            return ContainerRuntime.DOCKER;
-        } else if (ContainerRuntime.PODMAN.name().equalsIgnoreCase(runtime)) {
-            return ContainerRuntime.PODMAN;
-        } else if (ContainerRuntime.UNAVAILABLE.name().equalsIgnoreCase(runtime)) {
-            return ContainerRuntime.UNAVAILABLE;
-        } else {
+        }


Moved that logic to the enum and simplified things a bit. Would appreciate a second pair of eyes to make sure I didn't break something.

gsmet · 2023-03-16T13:30:06Z

...r/deployment/src/main/java/io/quarkus/container/image/docker/deployment/DockerProcessor.java

        return new RuntimeException(
-                "Execution of 'docker " + String.join(" ", dockerArgs) + "' failed. See docker output for more details");
+                "Execution of '" + executableName + " " + String.join(" ", dockerArgs)


Given we are not always using docker, let's make the message accurate.

gsmet · 2023-03-16T13:30:34Z

test-framework/junit5/src/main/java/io/quarkus/test/junit/IntegrationTestUtil.java

@@ -65,7 +65,6 @@ public final class IntegrationTestUtil {
    public static final int DEFAULT_PORT = 8081;
    public static final int DEFAULT_HTTPS_PORT = 8444;
    public static final long DEFAULT_WAIT_TIME_SECONDS = 60;
-    public static final ContainerRuntimeUtil.ContainerRuntime CONTAINER_RUNTIME = detectContainerRuntime(false);


Let's avoid doing that statically in a widely used util.

Karm · 2023-03-16T14:36:48Z

Thx @gsmet, I am walking through the scenarios atm...

Karm · 2023-03-16T15:50:16Z

@gsmet I think it's fine, both Linux and Windows, podman, docker, nothing, plain tests, dev mode, native build in container, docker extension...

CI failure here: Not sure. Do you find it related?

BTW, I am running JDK 17 and apparently the formatter picked up these:

diff --git a/integration-tests/java-17/src/main/java/io/quarkus/it/hibernate/panache/person/PersonResource.java b/integration-tests/java-17/src/main/java/io/quarkus/it/hibernate/panache/person/PersonResource.java
index 0bf2c3756b..7935235a7c 100644
--- a/integration-tests/java-17/src/main/java/io/quarkus/it/hibernate/panache/person/PersonResource.java
+++ b/integration-tests/java-17/src/main/java/io/quarkus/it/hibernate/panache/person/PersonResource.java
@@ -25,7 +25,6 @@ public Response addPerson(Person person) {
         return Response.created(URI.create("/persons/entity/" + id)).build();
     }
 
-
     @GET
     @Path("hql-project")
     @Transactional
diff --git a/integration-tests/java-17/src/test/java/io/quarkus/it/hibernate/panache/person/PersonResourceTest.java b/integration-tests/java-17/src/test/java/io/quarkus/it/hibernate/panache/person/PersonResourceTest.java
index bbc5a7df07..601241f450 100644
--- a/integration-tests/java-17/src/test/java/io/quarkus/it/hibernate/panache/person/PersonResourceTest.java
+++ b/integration-tests/java-17/src/test/java/io/quarkus/it/hibernate/panache/person/PersonResourceTest.java
@@ -4,11 +4,11 @@
 import static io.restassured.RestAssured.when;
 import static org.hamcrest.CoreMatchers.is;
 
-import io.quarkus.test.TestTransaction;
 import org.junit.jupiter.api.Test;
 
 import io.quarkus.it.mongodb.panache.person.Person;
 import io.quarkus.it.mongodb.panache.person.Status;
+import io.quarkus.test.TestTransaction;
 import io.quarkus.test.common.QuarkusTestResource;
 import io.quarkus.test.h2.H2DatabaseTestResource;
 import io.quarkus.test.junit.QuarkusTest;

gsmet

Let's merge!

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.201.0` -> `^0.203.0`](https://renovatebot.com/diffs/npm/flow-bin/0.201.0/0.203.1) | | [com.rometools:rome](http://rometools.com) ([source](https://github.com/rometools/rome)) | compile | minor | `2.0.0` -> `2.1.0` | | [org.postgresql:postgresql](https://jdbc.postgresql.org) ([source](https://github.com/pgjdbc/pgjdbc)) | build | minor | `42.5.4` -> `42.6.0` | | [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) | build | minor | `2.34.0` -> `2.35.0` | | [org.apache.maven.plugins:maven-resources-plugin](https://maven.apache.org/plugins/) | build | patch | `3.3.0` -> `3.3.1` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `2.16.4.Final` -> `2.16.6.Final` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `2.16.4.Final` -> `2.16.6.Final` | --- ### Release Notes <details> <summary>flowtype/flow-bin</summary> ### [`v0.203.1`](flow/flow-bin@0c16b26...5e0645d) [Compare Source](flow/flow-bin@0c16b26...5e0645d) ### [`v0.203.0`](flow/flow-bin@861f798...0c16b26) [Compare Source](flow/flow-bin@861f798...0c16b26) ### [`v0.202.1`](flow/flow-bin@2b48bba...861f798) [Compare Source](flow/flow-bin@2b48bba...861f798) ### [`v0.202.0`](flow/flow-bin@86aea9c...2b48bba) [Compare Source](flow/flow-bin@86aea9c...2b48bba) </details> <details> <summary>rometools/rome</summary> ### [`v2.1.0`](https://github.com/rometools/rome/releases/tag/2.1.0) [Compare Source](rometools/rome@2.0.0...2.1.0)  #### What's Changed ##### ⭐ New Features - Downgrade Java from version 11 to 8 by [@PatrickGotthard](https://github.com/PatrickGotthard) in rometools/rome#642 - Add support for GraalVM native images by [@artembilan](https://github.com/artembilan) in rometools/rome#636 ##### 🔨 Dependency Upgrades - Bump maven-compiler-plugin from 3.10.1 to 3.11.0 by [@dependabot](https://github.com/dependabot) in rometools/rome#635 ##### 🧹 Cleanup - Remove unused config files by [@PatrickGotthard](https://github.com/PatrickGotthard) in rometools/rome#632 - Polish GitHub workflows by [@PatrickGotthard](https://github.com/PatrickGotthard) in rometools/rome#633 - Polish code by [@antoniosanct](https://github.com/antoniosanct) in rometools/rome#631 ##### ✔ Other Changes - Update configuration for automatically generated release notes by [@PatrickGotthard](https://github.com/PatrickGotthard) in rometools/rome#634 #### New Contributors - [@artembilan](https://github.com/artembilan) made their first contribution in rometools/rome#636 **Full Changelog**: rometools/rome@2.0.0...2.1.0 </details> <details> <summary>pgjdbc/pgjdbc</summary> ### [`v42.6.0`](https://github.com/pgjdbc/pgjdbc/blob/HEAD/CHANGELOG.md#4260-2023-03-17-153434--0400) ##### Changed fix: use PhantomReferences instead of `Obejct.finalize()` to track Connection leaks [MR #2847](pgjdbc/pgjdbc#2847) The change replaces all uses of Object.finalize with PhantomReferences. The leaked resources (Connections) are tracked in a helper thread that is active as long as there are connections in use. By default, the thread keeps running for 30 seconds after all the connections are released. The timeout is set with pgjdbc.config.cleanup.thread.ttl system property. refactor:(loom) replace the usages of synchronized with ReentrantLock [MR #2635](pgjdbc/pgjdbc#2635) Fixes [Issue #1951](pgjdbc/pgjdbc#1951) </details> <details> <summary>diffplug/spotless</summary> ### [`v2.35.0`](https://github.com/diffplug/spotless/blob/HEAD/CHANGES.md#2350---2023-02-10) ##### Added - CleanThat Java Refactorer. ([#1560](diffplug/spotless#1560)) - Introduce `LazyArgLogger` to allow for lazy evaluation of log messages in slf4j logging. ([#1565](diffplug/spotless#1565)) ##### Fixed - Allow multiple instances of the same npm-based formatter to be used by separating their `node_modules` directories. ([#1565](diffplug/spotless#1565)) - `ktfmt` default style uses correct continuation indent. ([#1562](diffplug/spotless#1562)) ##### Changes - Bump default `ktfmt` version to latest `0.42` -> `0.43` ([#1561](diffplug/spotless#1561)) - Bump default `jackson` version to latest `2.14.1` -> `2.14.2` ([#1536](diffplug/spotless#1536)) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v2.16.6.Final`](https://github.com/quarkusio/quarkus/releases/tag/2.16.6.Final) [Compare Source](quarkusio/quarkus@2.16.5.Final...2.16.6.Final) ##### Complete changelog - [#32319](quarkusio/quarkus#32319) - \[2.16] Revert io.netty.noUnsafe change - [#32302](quarkusio/quarkus#32302) - Qute - fix validation of expressions with the "cdi" namespace - [#32253](quarkusio/quarkus#32253) - (2.16) Upgrade to graphql-java 19.4 - [#32223](quarkusio/quarkus#32223) - (2.16) Upgrade wildfly-elytron to 1.20.3.Final - [#32110](quarkusio/quarkus#32110) - Prevent splitting of cookie header values when using AWS Lambda - [#32107](quarkusio/quarkus#32107) - Fix Podman detection on Windows - [#32106](quarkusio/quarkus#32106) - Native building with container: Podman not detected on Windows - [#32093](quarkusio/quarkus#32093) - Re-use current ApplicationModel for JaCoCo reports when testing Gradle projects - [#32090](quarkusio/quarkus#32090) - K8s moved its registry - [#32088](quarkusio/quarkus#32088) - Remove the session cookie if ID token verification failed - [#32082](quarkusio/quarkus#32082) - Add missing quote in Hibernate Reactive with Panache guide - [#32079](quarkusio/quarkus#32079) - Quarkus JaCoCo extension fails to start Gradle daemon - [#32058](quarkusio/quarkus#32058) - Allow use of null in REST Client request body - [#32047](quarkusio/quarkus#32047) - rest client reactive throws npe on null request body - [#32041](quarkusio/quarkus#32041) - K8s is moving it's images - [#32037](quarkusio/quarkus#32037) - Set-Cookie Header is Split when using OIDC together with AWS Lambda - [#32015](quarkusio/quarkus#32015) - Support repeatable Incomings annotation for reactive messaging - [#32002](quarkusio/quarkus#32002) - Quarkus: Kafka Event Processor with 2 `@incoming` annotations throws Null Pointer SRMSG00212 - [#31984](quarkusio/quarkus#31984) - Only substitute OctetKeyPair\* classes when on the classpath - [#31978](quarkusio/quarkus#31978) - Remove quarkus.hibernate-orm.database.generation=drop-and-create from Hibernate ORM codestart - [#31930](quarkusio/quarkus#31930) - Native build fails for JWT - [#31893](quarkusio/quarkus#31893) - Docker or Podman required for tests since 3.0.0.Alpha6 - [#31857](quarkusio/quarkus#31857) - Container runtime detection cached in sys prop, container-docker extension - [#31811](quarkusio/quarkus#31811) - Check the expiry date for inactive OIDC tokens - [#31717](quarkusio/quarkus#31717) - Quarkus OIDC Session Cookie not deleted in case of 401 unauthorized - [#31714](quarkusio/quarkus#31714) - OIDC token refresh fails with 401, if user info is used and not available in the cache (anymore) - [#31662](quarkusio/quarkus#31662) - Warning when docker is not running - [#31525](quarkusio/quarkus#31525) - Bump Keycloak version to 21.0.1 - [#31490](quarkusio/quarkus#31490) - Enable Podman and Docker Windows quarkus-container-image-docker testing - [#31307](quarkusio/quarkus#31307) - Native Build on Windows has incorrect resource slashes - [#30383](quarkusio/quarkus#30383) - Create a new base classloader including parent-first test scoped dependencies when bootstrapping for CT ### [`v2.16.5.Final`](https://github.com/quarkusio/quarkus/releases/tag/2.16.5.Final) [Compare Source](quarkusio/quarkus@2.16.4.Final...2.16.5.Final) ##### Complete changelog - [#31959](quarkusio/quarkus#31959) - New home for Narayana LRA coordinator Docker images - [#31931](quarkusio/quarkus#31931) - Support raw collections in RESTEasy Reactive server and client - [#31922](quarkusio/quarkus#31922) - Add more lenient Liquibase ZipPathHandler to work around includeAll not working in prod mode - [#31904](quarkusio/quarkus#31904) - \[2.16] Upgrade SmallRye GraphQL to 1.9.4 - [#31894](quarkusio/quarkus#31894) - Supply missing extension metadata for reactive keycloak client - [#31891](quarkusio/quarkus#31891) - Fix truststore REST Client config when password is not set - [#31867](quarkusio/quarkus#31867) - Qute type-safe fragments - fix validation for loop metadata and globals - [#31866](quarkusio/quarkus#31866) - The behavior of the `@RestHeader` annotation is different from the `@HeaderParam` annotation when the parameter is of type List - [#31864](quarkusio/quarkus#31864) - Fix incorrect generic type passed to MessageBodyWriter#writeTo - [#31818](quarkusio/quarkus#31818) - Jackson JAX-RS YAML Provider for Resteasy Reactive - [#31804](quarkusio/quarkus#31804) - \[2.16] A test to make sure non-existing modules are ignored during workspace discovery - [#31793](quarkusio/quarkus#31793) - \[2.16] Fix NPE loading workspace modules - [#31770](quarkusio/quarkus#31770) - Fix native compilation when using quarkus-jdbc-oracle with elasticsearch-java - [#31769](quarkusio/quarkus#31769) - Capability added for quarkus-rest-client-reactive-jackson - [#31756](quarkusio/quarkus#31756) - quarkus-rest-client-reactive-jackson doesn't provide capabilities - [#31728](quarkusio/quarkus#31728) - Register additional cache implementations for reflection - [#31718](quarkusio/quarkus#31718) - Properly close metadata file in integration tests - [#31713](quarkusio/quarkus#31713) - "Too many open files" When test native image. - [#31712](quarkusio/quarkus#31712) - Make request scoped beans work properly in ReaderInterceptors - [#31705](quarkusio/quarkus#31705) - Remove all dev services for kubernetes dependencies from kubernetes-client-internal - [#31692](quarkusio/quarkus#31692) - RequestScoped context not active when using a ReaderInterceptor with large HTTP requests - [#31688](quarkusio/quarkus#31688) - Suppress config changed warning for quarkus.test.arg-line - [#31643](quarkusio/quarkus#31643) - Fix iterator issue when executing a zrange with score on a missing key - [#31626](quarkusio/quarkus#31626) - quarkus.test.arg-line has become a built-time fixed property in 2.16.4 - [#31624](quarkusio/quarkus#31624) - native compilation : quarkus-jdbc-oracle with elasticsearch-java strange behaviour - [#31617](quarkusio/quarkus#31617) - Bump Stork version 1.4.2 - [#31579](quarkusio/quarkus#31579) - Reinitialize sun.security.pkcs11.P11Util at runtime - [#31560](quarkusio/quarkus#31560) - Prevent SSE writing from potentially causing accumulation of headers - [#31559](quarkusio/quarkus#31559) - `SseUtil` unexpectedly stores headers in `Serialisers.EMPTY_MULTI_MAP` - [#31551](quarkusio/quarkus#31551) - Scheduler - detect scheduled methods of the same name on a class - [#31547](quarkusio/quarkus#31547) - Scheduler - it's possible to declare two scheduled methods of the same name on the same class - [#31545](quarkusio/quarkus#31545) - Append System.lineSeparator() to config error messages - [#31536](quarkusio/quarkus#31536) - Missing newline characters in config error message - [#31532](quarkusio/quarkus#31532) - Interpret negative/zero body-limit as infinite when logging REST Client request body - [#31523](quarkusio/quarkus#31523) - Request rejected by CORS for fonts in dev UI when `quarkus.http.cors=true` is set - [#31496](quarkusio/quarkus#31496) - Filter out RESTEasy related warning in ProviderConfigInjectionWarningsTest - [#31482](quarkusio/quarkus#31482) - Remove incorrect default value for keepAliveEnabled - [#31440](quarkusio/quarkus#31440) - Several quarkus integration tests fail to compile to native with latest GraalVM master - [#31384](quarkusio/quarkus#31384) - Ignore required documentation for `@ConfigMapping` default methods - [#30757](quarkusio/quarkus#30757) - Allow same origin CORS requests without 3rd party origins being configured - [#30744](quarkusio/quarkus#30744) - \[Quarkus Native] ClassNotFoundException: com.github.benmanes.caffeine.cache.SSSW - [#30698](quarkusio/quarkus#30698) - CORS Request same origin ignored if no other origin set </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v2.16.6.Final`](quarkusio/quarkus-platform@2.16.5.Final...2.16.6.Final) [Compare Source](quarkusio/quarkus-platform@2.16.5.Final...2.16.6.Final) ### [`v2.16.5.Final`](quarkusio/quarkus-platform@2.16.4.Final...2.16.5.Final) [Compare Source](quarkusio/quarkus-platform@2.16.4.Final...2.16.5.Final) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Looking at how this works right now the process is the following: 1. If the user has set `quarkus.native.container-runtime`, Quarkus uses this verbatim [1] (so if you want rootless you have to say `podman-rootless` instead of just `podman` 2. If `quarkus.native.container-runtime` is not set Quarkus next picks up the system property `quarkus-local-container-runtime` [2], this was introduced in quarkusio#31857 and is expected to be set by Quarkus and not the user, so the first time we try to detect the container runtime it should be unset. 3. If the system property is unset, Quarkus then checks the parameter `quarkus.native.container-runtime` (again) [3]. If it's set it uses it to test if the set runtime is available or not. If it's not available it falls back to testing first docker and then podman [4]. As a result, removing step 1 allows Quarkus to properly check the value of `quarkus.native.container-runtime` and fully resolve the runtime. [1] https://github.com/quarkusio/quarkus/blob/f3f97198a3a6892a828540811e0644fad7397acf/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildContainerRunner.java#L31 [2] https://github.com/quarkusio/quarkus/blob/f652f64823f4c54018344c2c941d9819ca9c3d72/core/runtime/src/main/java/io/quarkus/runtime/util/ContainerRuntimeUtil.java#L43 [3] https://github.com/quarkusio/quarkus/blob/f652f64823f4c54018344c2c941d9819ca9c3d72/core/runtime/src/main/java/io/quarkus/runtime/util/ContainerRuntimeUtil.java#L48 [4] https://github.com/quarkusio/quarkus/blob/f652f64823f4c54018344c2c941d9819ca9c3d72/core/runtime/src/main/java/io/quarkus/runtime/util/ContainerRuntimeUtil.java#L96C1-L111 Closes: quarkusio#34725

Looking at how this works right now the process is the following: 1. If the user has set `quarkus.native.container-runtime`, Quarkus uses this verbatim [1] (so if you want rootless you have to say `podman-rootless` instead of just `podman` 2. If `quarkus.native.container-runtime` is not set Quarkus next picks up the system property `quarkus-local-container-runtime` [2], this was introduced in quarkusio#31857 and is expected to be set by Quarkus and not the user, so the first time we try to detect the container runtime it should be unset. 3. If the system property is unset, Quarkus then checks the parameter `quarkus.native.container-runtime` (again) [3]. If it's set it uses it to test if the set runtime is available or not. If it's not available it falls back to testing first docker and then podman [4]. As a result, removing step 1 allows Quarkus to properly check the value of `quarkus.native.container-runtime` and fully resolve the runtime. [1] https://github.com/quarkusio/quarkus/blob/f3f97198a3a6892a828540811e0644fad7397acf/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildContainerRunner.java#L31 [2] https://github.com/quarkusio/quarkus/blob/f652f64823f4c54018344c2c941d9819ca9c3d72/core/runtime/src/main/java/io/quarkus/runtime/util/ContainerRuntimeUtil.java#L43 [3] https://github.com/quarkusio/quarkus/blob/f652f64823f4c54018344c2c941d9819ca9c3d72/core/runtime/src/main/java/io/quarkus/runtime/util/ContainerRuntimeUtil.java#L48 [4] https://github.com/quarkusio/quarkus/blob/f652f64823f4c54018344c2c941d9819ca9c3d72/core/runtime/src/main/java/io/quarkus/runtime/util/ContainerRuntimeUtil.java#L96C1-L111 Closes: quarkusio#34725 (cherry picked from commit e2d6b36)

Karm requested review from gsmet and geoand March 15, 2023 10:08

Karm self-assigned this Mar 15, 2023

quarkus-bot bot added the area/core label Mar 15, 2023

This comment has been minimized.

Sign in to view

quarkus-bot bot added the area/testing label Mar 15, 2023

This comment has been minimized.

Sign in to view

Karm force-pushed the followup-to-pr-31490 branch from 62f0b6c to f6c0f1a Compare March 15, 2023 22:34

This comment has been minimized.

Sign in to view

Karm mentioned this pull request Mar 15, 2023

Make podman first class citizens for quarkus usecases #31253

Open

6 tasks

Karm changed the title ~~[WIP] Swaps container runtime caching from file to sys prop~~ Container runtime detection cached in sys prop, container-docker extension Mar 15, 2023

This comment has been minimized.

Sign in to view

Karm added 4 commits March 16, 2023 08:59

Swaps container runtime caching from file to sys prop

4c449e0

Remove superflous calls to podman/docker on podman only/docker only box

f8c61cf

Similar to AppCDSBuildStep, IntegrationTestUtil needs to handle a sit…

781eb53

…uation\nwhere there is no container runtime working and none is needed.

Container Image Docker: uses Core autodetection too

ea1728b

Karm force-pushed the followup-to-pr-31490 branch from f6c0f1a to ea1728b Compare March 16, 2023 08:00

Karm mentioned this pull request Mar 16, 2023

Docker or Podman required for tests since 3.0.0.Alpha6 #31893

Closed

Karm linked an issue Mar 16, 2023 that may be closed by this pull request

Docker or Podman required for tests since 3.0.0.Alpha6 #31893

Closed

This comment has been minimized.

Sign in to view

Various adjustments for the container detection

38d3c0d

gsmet reviewed Mar 16, 2023

View reviewed changes

gsmet mentioned this pull request Mar 17, 2023

mvn test fails since 3.0.0.Alpha6 and custom junit-platform.properties #31924

Closed

gsmet approved these changes Mar 17, 2023

View reviewed changes

gsmet merged commit 351fcd3 into quarkusio:main Mar 17, 2023

gsmet added the triage/backport? label Mar 25, 2023

gsmet added this to the 2.16.6.Final milestone Mar 25, 2023

gsmet removed the triage/backport? label Mar 25, 2023

zakkak mentioned this pull request Jul 18, 2023

Fix container builds when explicitly setting container-runtime #34805

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Container runtime detection cached in sys prop, container-docker extension #31857

Container runtime detection cached in sys prop, container-docker extension #31857

Karm commented Mar 15, 2023 •

edited

Loading

quarkus-bot bot commented Mar 15, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Karm commented Mar 16, 2023

geoand commented Mar 16, 2023

This comment has been minimized.

gsmet commented Mar 16, 2023

gsmet left a comment

gsmet Mar 16, 2023

gsmet Mar 16, 2023

gsmet Mar 16, 2023

gsmet Mar 16, 2023

gsmet Mar 16, 2023

gsmet Mar 16, 2023

gsmet Mar 16, 2023

Karm commented Mar 16, 2023

Karm commented Mar 16, 2023

gsmet left a comment

		@@ -1,6 +1,5 @@
		package io.quarkus.deployment.pkg.steps;

		import static io.quarkus.deployment.pkg.steps.AppCDSBuildStep.CONTAINER_RUNTIME;

Container runtime detection cached in sys prop, container-docker extension #31857

Container runtime detection cached in sys prop, container-docker extension #31857

Conversation

Karm commented Mar 15, 2023 • edited Loading

quarkus-bot bot commented Mar 15, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Karm commented Mar 16, 2023

geoand commented Mar 16, 2023

This comment has been minimized.

gsmet commented Mar 16, 2023

gsmet left a comment

Choose a reason for hiding this comment

gsmet Mar 16, 2023

Choose a reason for hiding this comment

gsmet Mar 16, 2023

Choose a reason for hiding this comment

gsmet Mar 16, 2023

Choose a reason for hiding this comment

gsmet Mar 16, 2023

Choose a reason for hiding this comment

gsmet Mar 16, 2023

Choose a reason for hiding this comment

gsmet Mar 16, 2023

Choose a reason for hiding this comment

gsmet Mar 16, 2023

Choose a reason for hiding this comment

Karm commented Mar 16, 2023

Karm commented Mar 16, 2023

gsmet left a comment

Choose a reason for hiding this comment

Karm commented Mar 15, 2023 •

edited

Loading