Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Infinispan 14.0.7.Final #31844

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

karesti
Copy link
Member

@karesti karesti commented Mar 14, 2023

No description provided.

@karesti karesti requested a review from gsmet March 14, 2023 18:15
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/infinispan Infinispan labels Mar 14, 2023
@gsmet
Copy link
Member

gsmet commented Mar 15, 2023

I had a discussion with @karesti today and here is the outcome:

  • Javassist was always used by Protostream but it was shaded before thus why the Quarkus build was not complaining
  • Rewriting to ByteBuddy or another option is not trivial as Protostream uses the ability to write source code and have Javassist to parse the source code and transform it to bytecode. This for a non trivial amount of code. Rewriting this part to use the ByteBuddy DSL would be a tedious task and probably not as maintainable in the long term. Rewriting using ByteBuddy templating feature could work but I presume the performances would be a bit worse as the source code generated by Protostream is full of conditionals to optimize the different cases.

So for now, it was decided to let Javassist in and remove the banned dependency. I don't think it's a big risk of having Javassist crawling back as it's not that widely used nowadays.

@karesti karesti marked this pull request as ready for review March 15, 2023 16:09
@quarkus-bot

This comment has been minimized.

@gsmet gsmet force-pushed the infinispan-14.0.7.Final branch from 25e3da5 to 7fc4e46 Compare March 21, 2023 18:13
@gsmet gsmet merged commit c477055 into quarkusio:main Mar 21, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 21, 2023
@gsmet gsmet changed the title Updates to Infinispan 14.0.7.Final Update to Infinispan 14.0.7.Final Mar 21, 2023
@karesti karesti deleted the infinispan-14.0.7.Final branch March 22, 2023 11:23
@gsmet gsmet modified the milestones: 3.0.0.Beta1, 2.13.8.Final May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/infinispan Infinispan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants