-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace wildcard imports with specific imports for better code maintainability #31823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for the review, Sanne |
This comment has been minimized.
This comment has been minimized.
Job got an error because of this ->"check (check-imports) on project ...: Imports are not sorted in .." |
This comment has been minimized.
This comment has been minimized.
67df9fd
to
f486cf4
Compare
Please check https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style In particular this might be useful:
|
This comment has been minimized.
This comment has been minimized.
Could you please ensure formatting is working fine before sending more updates, we can't have CI work just for you :) |
I force pushed the formatting fixes, please don't touch this PR anymore, it should be good to go, now. Thanks. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Thanks. |
Thanks Sanne, I am going to check more carefully. |
I will be more careful next time. I appreciate advice. |
I appreciate a hand, Gsmet. |
In the project's codebase, there are many instances of wildcard imports being used to import all names from a module or package. This can lead to naming collisions and make it harder to understand where certain variables and functions are coming from.
Fixes #31789