Bump smallrye-open-api from 3.2.0 to 3.3.0, fix OpenAPI security issues #31671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
|
@phillip-kruger , please take a look if you get a chance |
|
@MikeEdgar nice ! let's get this in. I assume you will do the SR release ? |
Yep, I'll do it now. Thanks for the reviews 😃 |
MikeEdgar
force-pushed
the
openapi-update+bug-fixes
branch
from
43c49de to
5ec7d2c
Compare
This comment has been minimized.
This comment has been minimized.
|
@MikeEdgar the test failure is definitely related. Could you have a look? Thanks! |
- Handle method-level `@RolesAllowed` that override class-level `@RolesAllowed` values, fixes quarkusio#30997 - Render `BaseStream<T, S>` as array of `T` in OpenAPI document, fixes quarkusio#30248 (via smallrye-open-api 3.3.0) - Do not place scopes in OpenAPI security requirements unless the security scheme is OAuth2 or OIDC, fixes quarkusio#27373 - Include only OIDC discovery URL in OpenAPI when auto-security is active, fixes quarkusio#21126 Signed-off-by: Michael Edgar <[email protected]>
MikeEdgar
force-pushed
the
openapi-update+bug-fixes
branch
from
5ec7d2c to
b11fae5
Compare
michalvavrik
added a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Mar 10, 2023
With quarkusio/quarkus#31671 expected behavior of Smallrye OpenAPI has changed (torwards the specification) in regards to expected security scheme for basic authentication. We can't expect any value for 'basic' auth in Spring Data module now, therefore I added additional tests to Keycloak extended modules so that we have tested scenarios when security scheme is not empty.
9 tasks
michalvavrik
added a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Mar 14, 2023
With quarkusio/quarkus#31671 expected behavior of Smallrye OpenAPI has changed (torwards the specification) in regards to expected security scheme for basic authentication. We can't expect any value for 'basic' auth in Spring Data module now, therefore I added additional tests to Keycloak extended modules so that we have tested scenarios when security scheme is not empty.
michalvavrik
added a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Mar 14, 2023
With quarkusio/quarkus#31671 expected behavior of Smallrye OpenAPI has changed (torwards the specification) in regards to expected security scheme for basic authentication. We can't expect any value for 'basic' auth in Spring Data module now, therefore I added additional tests to Keycloak extended modules so that we have tested scenarios when security scheme is not empty.
fedinskiy
pushed a commit
to quarkus-qe/quarkus-test-suite
that referenced
this pull request
Mar 14, 2023
With quarkusio/quarkus#31671 expected behavior of Smallrye OpenAPI has changed (torwards the specification) in regards to expected security scheme for basic authentication. We can't expect any value for 'basic' auth in Spring Data module now, therefore I added additional tests to Keycloak extended modules so that we have tested scenarios when security scheme is not empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RolesAllowedthat override class-level@RolesAllowedvalues, fixes OpenAPI does not correctly generate security schema when @RolesAllowed is used #30997BaseStream<T, S>as array ofTin OpenAPI document, fixes openapi for RestResponse<Stream<T>> not automaticly documenting T #30248 (via smallrye-open-api 3.3.0)