Qute type-safe messages - default bundle name strategy #2

[mkouba]

• follows up on Qute type-safe messages - change the default bundle name strategy #31299

[gastaldi]

LGTM, minor typo found

[michalvavrik]

So AppMessages will default to msg because it is top level class, but index is nested so it will default to Controller_index. To me, it is not intuitive. I also think using lowercase index is not practical as lint rules are not very flexible - how much user will really type it this way. Anyway, user can change it with @MessageBundle#value(), so it's just my opinion.

[mkouba]

So AppMessages will default to msg because it is top level class, but index is nested so it will default to Controller_index. To me, it is not intuitive.

I agree. On the other side, we do a similar thing with @CheckedTemplate already.

I also think using lowercase index is not practical as lint rules are not very flexible - how much user will really type it this way.

We just take the simple name of the message bundle interface as is; i.e. no conversion is performed.

Anyway, user can change it with @MessageBundle#value(), so it's just my opinion.

Exactly.

[github-actions]

🙈 The PR is closed and the preview is expired.

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.