-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle text blocks when creating Panache find query #31419
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we test this in the Java tests because they are our reference?
Thanks.
I'm not sure if the formatter supports text blocks in Java, it seems to fail no matter what I do. Shall I remove the Kotlin tests? They are pretty much identical. |
Quarkus supports Java 11. |
I've added the Java tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Failing Jobs - Building d0d60cb
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
@gsmet the CI failure seems to be non-related. Is it OK for you to merge it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's merge it!
Thanks for the contribution!
I filed this issue #31210 from my work account. This PR should fix it. I'm not really sure why one test is failing. As far as I can tell it doesn't seem related to my change, but this is my first time contributing so hopefully someone else can shed some light on that.
Fixes #31210