Add the ability to customize k8s client config #31398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Sgitario
requested changes
Feb 27, 2023
|
Good point. I'll update the PR tomorrow
…On Mon, Feb 27, 2023, 08:13 Jose Carvajal ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I'm missing some doc updates about this change and maybe a simple test to
cover this change.
—
Reply to this email directly, view it on GitHub
<#31398 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBMDPZXWJW4YGRDGEAVSTTWZRAW7ANCNFSM6AAAAAAVG4MGRI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
PR updated |
Sgitario
approved these changes
Feb 27, 2023
geoand
added
the
triage/waiting-for-ci
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This gives users the ability to alter the configuration provided by Quarkus in arbitrary ways The pattern implemented is exactly the same as the one used in other extensions Relates to: quarkusio#31395
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives users the ability to alter the
configuration provided by Quarkus in arbitrary ways
The pattern implemented is exactly the same as the one used in other extensions
Relates to: #31395