Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore required documentation for @ConfigMapping default methods #31384

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Ignore required documentation for @ConfigMapping default methods #31384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...processor/src/main/java/io/quarkus/annotation/processor/ExtensionAnnotationProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,20 +512,22 @@ private void processCtorConfigItem(ExecutableElement ctor, Properties javadocPro
final String docComment = getRequiredJavadoc(ctor);
final StringBuilder buf = new StringBuilder();
appendParamTypes(ctor, buf);
javadocProps.put(className + Constants.DOT + buf.toString(), docComment);
javadocProps.put(className + Constants.DOT + buf, docComment);
}

private void processMethodConfigItem(ExecutableElement method, Properties javadocProps, String className) {
final String docComment = getRequiredJavadoc(method);
final StringBuilder buf = new StringBuilder();
buf.append(method.getSimpleName().toString());
appendParamTypes(method, buf);
javadocProps.put(className + Constants.DOT + buf.toString(), docComment);
javadocProps.put(className + Constants.DOT + buf, docComment);
}

private void processMethodConfigMapping(ExecutableElement method, Properties javadocProps, String className) {
final String docComment = getRequiredJavadoc(method);
javadocProps.put(className + Constants.DOT + method.getSimpleName().toString(), docComment);
if (method.getModifiers().contains(Modifier.ABSTRACT)) {
final String docComment = getRequiredJavadoc(method);
javadocProps.put(className + Constants.DOT + method.getSimpleName().toString(), docComment);
}
}

private void processConfigGroup(RoundEnvironment roundEnv, TypeElement annotation) {
Expand Down
4 changes: 4 additions & 0 deletions ...xtension/runtime/src/main/java/io/quarkus/extest/runtime/config/TestMappingBuildTime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,8 @@ interface Group {
*/
String value();
}

default void mustNotRequireDocs() {

}
}