Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding server grpc netty permit-keep-alive-time and permit-keep-alive-without-calls #31287

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

faculbsz-sg
Copy link
Contributor

as configuration options

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 19, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/docs/feat/fix/refactor but be a proper sentence

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Feb 19, 2023
@faculbsz-sg faculbsz-sg changed the title feat: add server grpc netty permit-keep-alive-time and permit-keep-alive-without-calls Adding server grpc netty permit-keep-alive-time and permit-keep-alive-without-calls Feb 19, 2023
@faculbsz-sg
Copy link
Contributor Author

faculbsz-sg commented Feb 19, 2023

Hi, i am migrating a couple of plain grpc java services to use quarkus grpc.

Those services have some custom configurations that were recommended by grpc-java maintainers (grpc/grpc-java#8995) to solve a connection reset issue caused by the infrastructure where we are running our services (Google Cloud Run). We need to establish smaller keep alive values that netty server would allow, and indicate that they can be done when the service is not receiving any RPC call. For this we need to configure these 2 properties:

-permit keep alive time
-permit keep alive without calls

But unfortunately those options are not exposed by quarkus configuration, so after checking how the existing configurable option for the netty server was done (https://github.com/quarkusio/quarkus/pull/14957/files) i decided to do similar and open this pr.

Would you consider taking a look?

thanks!

@faculbsz-sg faculbsz-sg force-pushed the grpc-permit-keep-alive branch from 224ae5f to 6d42e34 Compare February 20, 2023 10:17
@cescoffier
Copy link
Member

Thanks! That's a nice addition!

@quarkus-bot

This comment has been minimized.

@cescoffier
Copy link
Member

Make sure you apply the formatter?

Can you build, and rebase?

@faculbsz-sg
Copy link
Contributor Author

@cescoffier omw

@faculbsz-sg faculbsz-sg force-pushed the grpc-permit-keep-alive branch from 6d42e34 to 20b5268 Compare February 27, 2023 18:19
@faculbsz-sg
Copy link
Contributor Author

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  09:04 min
[INFO] Finished at: 2023-02-27T19:21:49+01:00

@quarkus-bot

This comment has been minimized.

@faculbsz-sg
Copy link
Contributor Author

@cescoffier could you merge it? or i should rebase

@cescoffier
Copy link
Member

Can you squash the commits?

@faculbsz-sg faculbsz-sg force-pushed the grpc-permit-keep-alive branch from 20b5268 to 357ba30 Compare February 28, 2023 11:20
@faculbsz-sg
Copy link
Contributor Author

Can you squash the commits?

done!

@faculbsz-sg faculbsz-sg force-pushed the grpc-permit-keep-alive branch from 357ba30 to 1a716df Compare February 28, 2023 12:46
@cescoffier cescoffier added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier cescoffier merged commit 269da7b into quarkusio:main Feb 28, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants