Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ReflectiveClassBuildItem #31222

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Refactor ReflectiveClassBuildItem #31222

merged 1 commit into from
Feb 18, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 16, 2023 •
edited
Loading

Also properly mark things we want gone as deprecated and for removal.

Related to discussions in #31177 (review) .

@zakkak @ppalaga could you have a look?

@gsmet
Refactor ReflectiveClassBuildItem to push the Builder to users
fc50f65 
Also properly mark things we want gone as deprecated and for
removal.
@gsmet gsmet requested review from zakkak and ppalaga February 16, 2023 17:29
@gsmet gsmet marked this pull request as draft February 16, 2023 17:30
@gsmet gsmet mentioned this pull request Feb 16, 2023
Merged
ppalaga
ppalaga approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsmet !

@quarkus-bot

This comment has been minimized.

Sign in to view
zakkak
zakkak approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gsmet.

@gsmet gsmet marked this pull request as ready for review February 17, 2023 17:40
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 17, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 17, 2023

Failing Jobs - Building fc50f65

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
⌛ JVM Tests - JDK 11 Windows Upload gc.log ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

@gsmet gsmet merged commit 0f4a239 into quarkusio:main Feb 18, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 18, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 18, 2023
@zhfeng zhfeng mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppalaga ppalaga ppalaga approved these changes

@zakkak zakkak zakkak approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
3.0.0.Alpha5
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @zakkak @ppalaga