Fix gRPC codegen race condition #31102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good! LEt's see what the CI says. |
This comment has been minimized.
This comment has been minimized.
cescoffier
approved these changes
Feb 13, 2023
|
Unfortunately, this PR is in conflict now, could you rebase and fix the conflict? |
gsmet
added
the
triage/needs-rebase
gsmet
force-pushed
the
codegen_race_condition
branch
from
8ee1451 to
3d0dc7b
Compare
gsmet
removed
the
triage/needs-rebase
|
I rebased the PR, let's see what CI has to say. |
gsmet
added
the
triage/waiting-for-ci
Thanks |
Failing Jobs - Building 3d0dc7b
Full information is available in the Build summary check run. Failures⚙️ Maven Tests - JDK 11 #- Failing: integration-tests/maven
📦 integration-tests/maven✖ ✖ ⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖ ✖ |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cescoffier I add a lock to prevent compilation while generating sources. No more error so far. Shall we try it with quarkus CI ?