-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.13.x] - Update 2.13 to use the new container images #31001
Conversation
There is #30829 concern for S2I with the new images. Can you check it @cescoffier pls? |
This comment has been minimized.
This comment has been minimized.
In general we are moving to the new generation of builder images in 2.13 and I think we should be ok with that. But it's better to be safe, so I will check with my team mates. |
Let me fix the conflicts. |
- the builder images are now: quarkusubi-quarkus-graalvmce-builder-image and quarkusubi-quarkus-mandrel-builder-image. Both at multi-archs (AMD64 and ARM64). - the s2i images are now: quarkusubi-quarkus-native-binary-s2i:2.0 and quarkusubi-quarkus-graalvmce-s2i - the base images are now: quarkusquarkus-micro-image:2.0 and quarkusquarkus-distroless-image:2.0
4e761f6
to
034a084
Compare
Conflicts fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also 2 other places that are using 1.14
version
integration-tests/maven/src/test/resources-filtered/projects/codegen-config-factory/app/src/main/docker/Dockerfile.jvm:FROM registry.access.redhat.com/ubi8/openjdk-11:1.14
integration-tests/maven/src/test/resources-filtered/projects/codegen-config-factory/app/src/main/docker/Dockerfile.legacy-jar:FROM registry.access.redhat.com/ubi8/openjdk-11:1.14
I think all the versions of openjdk image should be synced (even though these are just tests and main is also using older 1.14)
@@ -15,7 +15,7 @@ public class S2iConfig { | |||
|
|||
public static final String DEFAULT_BASE_JVM_JDK11_IMAGE = "registry.access.redhat.com/ubi8/openjdk-11:1.14"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be openjdk-11:1.15
like in 2 other cases?
@@ -15,7 +15,7 @@ public class S2iConfig { | |||
|
|||
public static final String DEFAULT_BASE_JVM_JDK11_IMAGE = "registry.access.redhat.com/ubi8/openjdk-11:1.14"; | |||
public static final String DEFAULT_BASE_JVM_JDK17_IMAGE = "registry.access.redhat.com/ubi8/openjdk-17:1.14"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be openjdk-17:1.15
like in 2 other cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should and that's concerning as it looks like the previous backport didn't change them. I need to have a closer look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we are using a floating tag for these 2 in main so that's why they weren't updated in main and thus not backported.
I'll go fix that in an additional commit.
Failing Jobs - Building 8aca0ac
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for update @gsmet. I spoke with people in the team and we have no objections.
Update the Quarkus images to multi-archs variants