ArC - Fix ObserverTransformerTest #30968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutrymaco
force-pushed
the
fix_ObserverTransformerTest
branch
from
37bedf7 to
8d51972
Compare
Nutrymaco
force-pushed
the
fix_ObserverTransformerTest
branch
from
8d51972 to
6d2ebc3
Compare
mkouba
added
the
triage/waiting-for-ci
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
FYI I've added a similar test to the core test suite in #30987. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the test is supposed to check if the observer transformer is modifying observer method. But observer declared in test does nothing, but most likely supposed to remove
@AlphaQualifierfromMyObserver.onMyEventRemoveQualifiers().