Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes to observer methods to align them with spec expectations #30950

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Feb 7, 2023

Related to #28558

  • All OM now implement getReception() method correctly (before we just returned Reception.ALWAYS)
  • All OM now implement getDeclaringBean() through default method
  • We now support notify(T event) via default impl - there are TCKs asserting you can manually invoke the method on OM

@manovotn manovotn requested review from Ladicek and mkouba February 7, 2023 12:41
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Feb 7, 2023
@gsmet gsmet force-pushed the observerMethodImprovements branch from 45d1314 to 55d8fcc Compare February 7, 2023 12:52
@gsmet
Copy link
Member

gsmet commented Feb 7, 2023

I rebased on top of latest main due to some CI weirdness.

@manovotn manovotn force-pushed the observerMethodImprovements branch from 55d8fcc to 73480e6 Compare February 7, 2023 13:05
@Ladicek
Copy link
Contributor

Ladicek commented Feb 7, 2023

Otherwise LGTM.

@manovotn manovotn force-pushed the observerMethodImprovements branch from 73480e6 to 1361239 Compare February 7, 2023 13:20
@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 7, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2023

Failing Jobs - Building 1361239

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/mongodb-rest-data-panache 

📦 integration-tests/mongodb-rest-data-panache

io.quarkus.it.mongodb.rest.data.panache.MongoDbRestDataPanacheTest.shouldNotCreateOrDeleteAuthor - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

@manovotn
Copy link
Contributor Author

manovotn commented Feb 8, 2023

CI failures are unrelated

@manovotn manovotn merged commit 8c1937f into quarkusio:main Feb 8, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 8, 2023
@manovotn manovotn deleted the observerMethodImprovements branch February 8, 2023 10:51
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants