-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various changes to observer methods to align them with spec expectations #30950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
reviewed
Feb 7, 2023
...pendent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/ObserverGenerator.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
Feb 7, 2023
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/InjectableObserverMethod.java
Show resolved
Hide resolved
mkouba
reviewed
Feb 7, 2023
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/EventContextImpl.java
Outdated
Show resolved
Hide resolved
gsmet
force-pushed
the
observerMethodImprovements
branch
from
February 7, 2023 12:52
45d1314
to
55d8fcc
Compare
I rebased on top of latest main due to some CI weirdness. |
manovotn
force-pushed
the
observerMethodImprovements
branch
from
February 7, 2023 13:05
55d8fcc
to
73480e6
Compare
Ladicek
reviewed
Feb 7, 2023
...pendent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/ObserverGenerator.java
Outdated
Show resolved
Hide resolved
mkouba
approved these changes
Feb 7, 2023
Otherwise LGTM. |
manovotn
force-pushed
the
observerMethodImprovements
branch
from
February 7, 2023 13:20
73480e6
to
1361239
Compare
manovotn
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Feb 7, 2023
Ladicek
reviewed
Feb 7, 2023
...ts/arc/tests/src/test/java/io/quarkus/arc/test/observers/ifexists/ReceptionIfExistsTest.java
Show resolved
Hide resolved
Ladicek
approved these changes
Feb 7, 2023
Failing Jobs - Building 1361239
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/mongodb-rest-data-panache
📦 integration-tests/mongodb-rest-data-panache✖
|
CI failures are unrelated |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #28558
getReception()
method correctly (before we just returnedReception.ALWAYS
)getDeclaringBean()
through default methodnotify(T event)
via default impl - there are TCKs asserting you can manually invoke the method on OM