-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Hibernate ORM 5.6.15.Final #30946
Conversation
This comment has been minimized.
This comment has been minimized.
Don't merge this yet. Something went wrong with the CI. |
@famod I think something went wrong with GIB here. And the only culprit I could see would be the |
Or we also backport #30640 to 2.16? (That won't solve the 2.13 issue though) |
Given we want this in 2.13, maybe a PR targeting 2.16 that I could apply to 2.13 too would be better. |
Done: #30956 The labels on that PR might not be what you need; sorry about that, I'm not sure what to do when actually backporting since you always do it for me :) |
Failing Jobs - Building b189ead
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/mongodb-rest-data-panache
📦 integration-tests/mongodb-rest-data-panache✖
|
@famod it didn't fail per se but it didn't run the JVM tests nor the native tests: https://github.com/quarkusio/quarkus/actions/runs/4113233527 So something is off. |
@gsmet the delimiter differs: |
We are doing something related to that here: https://github.com/quarkusio/quarkus/pull/30867/files#diff-d8e36253822cffbdf21e333bcba467345b46e6095927dda98399fe7f21f4679aL168-R168 But I don't understand why it would change (except if GitHub is doing some magic). |
Ah, I vaguely remember that one. Since we don't convert |
So do you think we could just push the line feeds to the file without replacing them at all? Or do we need to change them back when we read the output? |
I'll try to find some time this evening to test this in a sample repo. |
Fixes #30234
Release notes for ORM 5.6.15.Final: https://in.relation.to/2023/02/06/hibernate-orm-5615-final/
Note this patch should apply cleanly to 2.16, at least for the Java part, as it does not rely on JPA classes directly.