Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vertx-kafka-client dependency from smallrye-reactive-messaging-kafka #30932

Merged

Conversation

ozangunalp
Copy link
Contributor

Fixes #22295

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/reactive-messaging area/smallrye labels Feb 6, 2023
@quarkus-bot

This comment has been minimized.

@ozangunalp ozangunalp force-pushed the remove_vertx_kafka_client_dependency branch from 5e10a15 to 17ad275 Compare February 7, 2023 11:49
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2023

Failing Jobs - Building 17ad275

Status Name Step Failures Logs Raw logs
MicroProfile TCKs Tests Verify Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-lra 

📦 tcks/microprofile-lra

org.eclipse.microprofile.lra.tck.TckCancelOnTests.cancelOn301 line 120 - More details - Source on GitHub

java.lang.AssertionError: Response status on call to 'http://localhost:8081/lraresource-cancelon/cancelOn301' failed to match. expected:<301> but was:<503>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)

org.eclipse.microprofile.lra.tck.TckCancelOnTests.cancelOnFamilyDefault4xx line 68 - More details - Source on GitHub

java.lang.AssertionError: Response status on call to 'http://localhost:8081/lraresource-cancelon/cancelOnFamilyDefault4xx' failed to match. expected:<400> but was:<503>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)

org.eclipse.microprofile.lra.tck.TckCancelOnTests.cancelOnFamilyDefault5xx line 84 - More details - Source on GitHub

java.lang.AssertionError: Response status on call to 'http://localhost:8081/lraresource-cancelon/cancelOnFamilyDefault5xx' failed to match. expected:<500> but was:<503>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)

org.eclipse.microprofile.lra.tck.TckCancelOnTests.notCancelOnFamily5xx line 140 - More details - Source on GitHub

java.lang.AssertionError: Response status on call to 'http://localhost:8081/lraresource-cancelon/notCancelOnFamily5xx' failed to match. expected:<500> but was:<503>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)

org.eclipse.microprofile.lra.tck.TckCancelOnTests.cancelOnFamily3xx line 100 - More details - Source on GitHub

java.lang.AssertionError: Response status on call to 'http://localhost:8081/lraresource-cancelon/cancelOnFamily3xx' failed to match. expected:<303> but was:<503>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)

org.eclipse.microprofile.lra.tck.TckCancelOnTests.cancelFromRemoteCall line 160 - More details - Source on GitHub

java.lang.AssertionError: Response status on call to 'http://localhost:8081/lraresource-cancelon/cancelFromRemoteCall' failed to match. expected:<200> but was:<503>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)

@gsmet gsmet requested a review from cescoffier February 8, 2023 09:53
@cescoffier
Copy link
Member

We need to document the change in the migration guide.

@ozangunalp ozangunalp merged commit ca96ab2 into quarkusio:main Feb 8, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 8, 2023
@ozangunalp ozangunalp deleted the remove_vertx_kafka_client_dependency branch February 8, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/reactive-messaging area/smallrye
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove vertx-kafka-client dependency
2 participants