Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep 2.x extensions codestarts embedded in tooling and mark them legacy #30923

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Feb 6, 2023

Keep javax.ws in base, those extensions codestarts are ONLY used with Quarkus platform 2.10 and below.
From 2.11 and onward, they are provided by the platform.

@ia3andy ia3andy force-pushed the fix-base-codestarts branch from 9b6673f to 3702f7d Compare February 6, 2023 13:17
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Feb 6, 2023
@ia3andy ia3andy requested a review from aloubyansky February 6, 2023 13:18
@aloubyansky
Copy link
Member

@ia3andy how are they going to be found in the new location? Is there some code doing it already? Or am I missing something?

@ia3andy
Copy link
Contributor Author

ia3andy commented Feb 6, 2023

@ia3andy how are they going to be found in the new location? Is there some code doing it already? Or am I missing something?

the directory has no importance as soon as it's below quarkus/

@quarkus-bot

This comment has been minimized.

@ia3andy ia3andy force-pushed the fix-base-codestarts branch from 3702f7d to cc4a8b7 Compare February 7, 2023 08:08
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2023

Failing Jobs - Building cc4a8b7

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18
Native Tests - Misc1 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/mongodb-rest-data-panache 

📦 integration-tests/mongodb-rest-data-panache

io.quarkus.it.mongodb.rest.data.panache.MongoDbRestDataPanacheTest.shouldNotCreateOrDeleteAuthor - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

@aloubyansky aloubyansky merged commit e48aace into quarkusio:main Feb 7, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants