Copied the Vert.x FileCache and FileResolverImpl to override a method allowing us to support the quarkus: URL scheme used by the QuarkusClassLoader #30820
+672
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allowing us to support the quarkus: URL scheme used by the QuarkusClassLoader Fixes quarkusio#28474
|
I assume that a more robust solution would be to provide some kind of SPI in Vert.x to allow for a pluggable protocol based resolution |
gsmet
added
the
triage/needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't ideal, because two Vert.x classes need to be copied. A better version of this fix would be if Vert.x added the
quarkus:protocol toFileResolverImpl, but at least we can test this before making a Vert.x release with that fix.Now, I'm not sure if we should merge this to solve this now, and fix it when Vert.x makes a release, or wait for the new Vert.x release?
Fixes #28474