-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple proxy client / server, relay #30777
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
FYI @vietj |
return VertxUtil | ||
.toPromise(context, channelFuture) | ||
.future() | ||
.map(v -> channelFuture.channel()) | ||
.onSuccess(ch -> { | ||
log.info("Proxy server listening on {} using {}", | ||
ch.localAddress(), Ssl.isEnabled(ssl) ? "SSL" : "TCP"); | ||
}) | ||
.onFailure(ex -> { | ||
log.error("Proxy server can't establish listening channel", ex); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try and limit the use of lambdas and streams as much as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
This is simple Future mapping / handling ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shy away from them as much possible for runtime code for runtime footprint reasons
I have no context about this, so I am not really sure what the intended purpose is here |
This comment has been minimized.
This comment has been minimized.
@geoand this is for @cescoffier to explain ... |
@geoand last year, we discussed building an API Gateway with Quarkus. This is not exactly what we want, but it has some interesting ideas. |
Aha. I thought that would be using |
No description provided.