Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple proxy client / server, relay #30777

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

alesj
Copy link
Contributor

@alesj alesj commented Feb 1, 2023

No description provided.

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 1, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@alesj alesj changed the title Add simple proxy client / server, relay. Add simple proxy client / server, relay Feb 1, 2023
@alesj
Copy link
Contributor Author

alesj commented Feb 1, 2023

FYI @vietj

Comment on lines +109 to +119
return VertxUtil
.toPromise(context, channelFuture)
.future()
.map(v -> channelFuture.channel())
.onSuccess(ch -> {
log.info("Proxy server listening on {} using {}",
ch.localAddress(), Ssl.isEnabled(ssl) ? "SSL" : "TCP");
})
.onFailure(ex -> {
log.error("Proxy server can't establish listening channel", ex);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try and limit the use of lambdas and streams as much as possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?
This is simple Future mapping / handling ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shy away from them as much possible for runtime code for runtime footprint reasons

@geoand
Copy link
Contributor

geoand commented Feb 1, 2023

I have no context about this, so I am not really sure what the intended purpose is here

@quarkus-bot

This comment has been minimized.

@alesj
Copy link
Contributor Author

alesj commented Feb 2, 2023

I have no context about this, so I am not really sure what the intended purpose is here

@geoand this is for @cescoffier to explain ...

@cescoffier
Copy link
Member

@geoand last year, we discussed building an API Gateway with Quarkus. This is not exactly what we want, but it has some interesting ideas.

@cescoffier cescoffier marked this pull request as draft February 2, 2023 13:28
@cescoffier cescoffier removed their request for review February 2, 2023 13:29
@geoand
Copy link
Contributor

geoand commented Feb 2, 2023

Aha. I thought that would be using Vert.x Http Prox for that

@gsmet gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/needs-rebase This PR needs to be rebased first because it has merge conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants