Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit mock-maker-inline configs #30730

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

famod
Copy link
Member

@famod famod commented Jan 30, 2023

It's the default now in Mockito 5.

It's the default now in Mockito 5.
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 30, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit a5f233d into quarkusio:main Jan 31, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 31, 2023
@gsmet
Copy link
Member

gsmet commented Jan 31, 2023

I'm not completely sure I like this change. Are we completely sure they won't change the default in the future to something that doesn't fit our purpose?

@famod famod deleted the mock-maker branch January 31, 2023 10:07
@famod
Copy link
Member Author

famod commented Jan 31, 2023

So I assumed that by upgrading to Mockito 5 we are ok with the default inline mock-maker.
If we want to give it some time to bake (e.g. wait for possible user feedback after 2.17 has been released) then we could revert this now preemptively. Alternatively we'd need to remember this change and only revert on demand.

But eventually I think this change does make sense. DRY, YAGNI, KISS and all that...
I also do think that we rely on certain defaults elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants