Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Netty to version 4.1.87.Final #30671

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Jan 27, 2023

Signed-off-by: Andrea Cosentino [email protected]

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jan 27, 2023
@gsmet gsmet requested a review from cescoffier January 27, 2023 18:04
@cescoffier
Copy link
Member

Anything special you need from the at release?

@oscerd
Copy link
Contributor Author

oscerd commented Jan 27, 2023

Not really, but this minor usually keep some minor fixes, so it's always good to keep up-to-date. If there are good reason to stay on .86 I'm fine :-)

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 27, 2023

Failing Jobs - Building 993c750

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18
Native Tests - Misc4 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/smallrye-graphql-client 

📦 integration-tests/smallrye-graphql-client

io.quarkus.it.smallrye.graphql.client.DynamicClientTest.testDynamicClientSubscription line 43 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/security/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 333 more

📦 extensions/security/deployment

io.quarkus.security.test.rolesallowed.RolesAllowedExpressionTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:689)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$12(ClassBasedTestDescriptor.java:395)

@cescoffier
Copy link
Member

We don't have a good reason to stay on .86. However, we are waiting for the "all clear" from the Vert.x team first.

@cescoffier
Copy link
Member

Just got the feedback from the Vert.x team. We should wait for .88 containing significant optimizations.

@gsmet
Copy link
Member

gsmet commented Jan 30, 2023

@cescoffier I suppose we can merge this in the meantime?

@cescoffier
Copy link
Member

Yes, we can merge this one waiting for .88.

@cescoffier cescoffier merged commit b3cb9ec into quarkusio:main Jan 31, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants