Diataxis restructure of NVD content and added more references to link security topics #30654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelle-purcell
force-pushed
the
doc-basic-auth
branch
from
9015137 to
9883b49
Compare
|
FYI: @inoxx03 , @MichalMaler , @sheilamjones , @rolfedh , @ebullient and @anyone-else-in-the-community - Review and feedback welcome. Thank you. |
|
🙈 The PR is closed and the preview is expired. |
ebullient
approved these changes
Jan 27, 2023
| Use HTTPS with Basic Authentication to avoid exposing the credentials. | ||
| The risk of exposing credentials as plain text increases if a load balancer terminates HTTPS, as the request is forwarded to Quarkus over HTTP. | ||
| == Limitations with using Basic authentication | ||
|
|
There was a problem hiding this comment.
Should we have a rule about allowing uppercase B for basic when followed by authentication? common warning here.
There was a problem hiding this comment.
I'm on it... [we added one recently to the vale-at-red-hat repo, I will reuse that and other enhancements since the last rule update].
Fixed NVD ref Fixed build errors
michelle-purcell
force-pushed
the
doc-basic-auth
branch
from
9883b49 to
f36373c
Compare
|
Nice work, thanks @michelle-purcell |
|
Thanks for reviewing @ebullient |
|
@ebullient & @sberyozkin: Thanks 👍 |
|
Again let's be more conservative with the doc backports. We cannot backport large changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the detailed content in the US National Vulnerability Database registration section from the Security overview topic to a new diataxis concept topic called Security vulnerability detection and reporting in Quarkus.
Connected the (somewhat isolated) Basic authentication concept to the other topics in this family*.
[*] - Observation: Enhancing the doc website UI by adding more navigation features that support Quarkus taxonomy could prevent the need to manually add and maintain lots of links & xrefs, like those added to this PR.