Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary to topic #30618

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jan 25, 2023

Fixes QDOCS-117

@rolfedh rolfedh force-pushed the oidc-bearer-auth-add-summ branch from 279a465 to 1aa81e4 Compare January 25, 2023 21:52
@github-actions
Copy link

github-actions bot commented Jan 25, 2023

🙈 The PR is closed and the preview is expired.

@sheilamjones sheilamjones self-requested a review January 26, 2023 11:12
@sheilamjones
Copy link
Contributor

Hi @rolfedh, looks great to me. Just had a minor question/comment about capitalization.

@sberyozkin sberyozkin merged commit 7dc5975 into quarkusio:main Jan 26, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 26, 2023
@rolfedh
Copy link
Contributor Author

rolfedh commented Jan 26, 2023

Hi @rolfedh, looks great to me. Just had a minor question/comment about capitalization.

Thanks. I went with the proper noun capitalization of "Bearer authentication" from the RFC, which I believe is intended to differentiate this specific authentication scheme from any generic bearer authentication scheme.

@@ -6,7 +6,9 @@ https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc
[id="security-oidc-bearer-authentication-concept"]
= OIDC Bearer authentication
include::_attributes.adoc[]
:categories: security
:categories: security,web

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfedh - Only saw this PR post-merge... The linebreak on line 10 breaks the preamble on the index page. Fixed in PR 30665.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants