Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hibernate-orm property: quarkus.hibernate-orm.validation.enabled #30617

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

mfpc
Copy link
Contributor

@mfpc mfpc commented Jan 25, 2023

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 25, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Jan 25, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 25, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@gastaldi gastaldi requested review from yrodiere and gsmet January 25, 2023 18:42
@mfpc mfpc force-pushed the hibernate-validation branch from f8fcf68 to e5e2f53 Compare January 25, 2023 18:53
@mfpc mfpc force-pushed the hibernate-validation branch from e5e2f53 to e5d57e2 Compare January 25, 2023 18:55
@mfpc mfpc changed the title Added hibernate-orm property: quarkus.hibernate-orm.validation.mode t… Added hibernate-orm property: quarkus.hibernate-orm.validation.enabled #30448 Jan 25, 2023
@quarkus-bot

This comment has been minimized.

@mfpc mfpc force-pushed the hibernate-validation branch from c0994f4 to cb98bdd Compare January 25, 2023 19:11
@mfpc mfpc force-pushed the hibernate-validation branch 2 times, most recently from e7179f7 to a1000a3 Compare January 25, 2023 19:31
@gastaldi gastaldi force-pushed the hibernate-validation branch from a1000a3 to 6ae53ba Compare January 25, 2023 19:31
@quarkus-bot

This comment has been minimized.

@gsmet gsmet force-pushed the hibernate-validation branch from 6ae53ba to e93a720 Compare January 26, 2023 11:06
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few minor changes and amended your commit. This should be good to go now.

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 26, 2023
@yrodiere
Copy link
Member

Looks good, let's merge once CI passes.

Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit 336ebc4 into quarkusio:main Jan 26, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 26, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 26, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 26, 2023
@gsmet gsmet changed the title Added hibernate-orm property: quarkus.hibernate-orm.validation.enabled #30448 Added hibernate-orm property: quarkus.hibernate-orm.validation.enabled Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/hibernate-orm Hibernate ORM area/oidc area/persistence OBSOLETE, DO NOT USE kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set validation mode using a hibernate-orm property
4 participants