Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated reactive datasource config properties #30556

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Remove deprecated reactive datasource config properties #30556

merged 1 commit into from
Feb 6, 2023

Conversation

tsegismont
Copy link
Contributor

  • thread local pool
  • prepared statement caching at Pg and MySQL level

@tsegismont tsegismont requested a review from geoand January 23, 2023 16:04
@tsegismont
Copy link
Contributor Author

@geoand this would be for Quarkus 3 only. Shall I create the PR against the 3.0 branch instead?

@geoand
Copy link
Contributor

geoand commented Jan 23, 2023

I don't think so. @gsmet ?

@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented Jan 26, 2023

Hmmm. Let's wait before merging it. Not yet sure if main will be 3 or not.

@gsmet
Copy link
Member

gsmet commented Feb 4, 2023

This needs a rebase to be compatible with the Jakarta-transformed main.

@gsmet gsmet added triage/needs-rebase This PR needs to be rebased first because it has merge conflicts and removed triage/quarkus-3 labels Feb 4, 2023
@tsegismont
Remove deprecated reactive datasource config properties
116d5a6 
- thread local pool
- prepared statement caching at Pg and MySQL level
@tsegismont tsegismont force-pushed the remove_deprecation_reactive_sql branch from d9f8e4f to 116d5a6 Compare February 6, 2023 09:09
@tsegismont
Copy link
Contributor Author

This needs a rebase to be compatible with the Jakarta-transformed main.

@gsmet done

@gsmet gsmet removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 6, 2023
gsmet
gsmet approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 6, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 6, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 5925a26 into quarkusio:main Feb 6, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 6, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 6, 2023
@tsegismont tsegismont deleted the remove_deprecation_reactive_sql branch March 13, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
area/persistence OBSOLETE, DO NOT USE area/reactive-sql-clients release/breaking-change
Projects
None yet
Milestone
3.0.0.Alpha4
Development

Successfully merging this pull request may close these issues.
4 participants
@tsegismont @geoand @gsmet @mkouba