Refactor to use new SignatureBuilder API by Gizmo in REST Data Panache #30554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
From quarkusio/gizmo#147, we can use the latest SignatureBuilder API. To use the new SignatureBuilder API, I had to deal with the gizmo type class, so more changes than expected were necessary.
Sgitario
force-pushed
the
use_new_gizmo_api
branch
from
2bf80ff to
88f8c3e
Compare
mkouba
approved these changes
Jan 24, 2023
mkouba
added
the
triage/waiting-for-ci
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From quarkusio/gizmo#147, we can use the latest SignatureBuilder API.
To use the new SignatureBuilder API, I had to deal with the gizmo type class, so more changes than expected were necessary.