Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc - compare types declared by @Typed with unrestricted bean types instead of actual types #30544

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Jan 23, 2023

This should fix the RR TCK execution discussed in #30501 (at least locally it does for me).

The comparison of types declared in @Typed now includes even types that will be removed from actual bean types (such as types with wildcard).
CDI spec part - https://jakarta.ee/specifications/cdi/2.0/cdi-spec-2.0.html#restricting_bean_types

If a bean class or producer method or field specifies a @Typed annotation, and the value member specifies a class which does not correspond to a type in the unrestricted set of bean types of a bean, the container automatically detects the problem and treats it as a definition error.

Fixes #30540

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jan 23, 2023
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member

gsmet commented Jan 23, 2023

CI looks happier, good point :). Let's see what @mkouba has to say about it before merging.

@mkouba mkouba merged commit d7643f9 into quarkusio:main Jan 24, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 24, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 24, 2023
@manovotn manovotn deleted the beanTypeRestrictionFix branch January 24, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed due to limit bean types to types outside of the transitive closure of bean types
5 participants