Actually forbid simultaneous use of persistence.xml and quarkus.hibernate-orm.* properties
#30409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/hibernate-orm
yrodiere
force-pushed
the
i16589-no-mixing-persistence-xml-and-quarkus-config
branch
from
7f36e65 to
71c9ec5
Compare
This comment has been minimized.
This comment has been minimized.
…us config with a persistence.xml in the classpath Some code dealing with implied PUs was preventing that failure from even happening... Also note we cannot catch *every* situation where we should fail, but we can try our best.
yrodiere
force-pushed
the
i16589-no-mixing-persistence-xml-and-quarkus-config
branch
from
71c9ec5 to
9749258
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
gsmet
approved these changes
Jan 18, 2023
|
Please add something to the migration guide. Thanks. |
|
Nice catch, thanks. FYI I do vaguely recall that we used to fail if both were present, but that seems to have gone lost. |
Done.
Yes this code probably used to work, but the corresponding test was not testing the right thing, so when it stopped working that went under the radar. |
yrodiere
deleted the
i16589-no-mixing-persistence-xml-and-quarkus-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16589
This sort of breaks backwards compatibility: we used to document that using
persistence.xmlalongsidequarkus.hibernate-orm.*properties was forbidden and would fail, but in practice we were more lenient and such situation just resulted inquarkus.hibernate-orm.*properties being ignored. Now, we will properly fail.I also added an INFO log when using
persistence.xml, because we cannot always detect that users mean to use Quarkus-configured PUs (since we tend to allow zero-config), so in some cases we might still just ignore Quarkus-configured PUs in favor ofpersistence.xml...