Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid JavaScript identifier in DevUI sourceMaps #30407

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

cescoffier
Copy link
Member

When using Gradle with extensions generating source code (gRPC, Avro...), the JavaScript identifiers used to build the source map were not valid (because they contained -).

This commit fixes it by replacing the - with _.

Fix #30288

…..), the JavaScript identifiers used to build the source map were not valid (because they contained `-`).

This commit fixes it by replacing the `-` with `_`.

Fix #30288
@cescoffier cescoffier requested a review from geoand January 17, 2023 07:57
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Jan 17, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 17, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier cescoffier merged commit 2264061 into main Jan 17, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 17, 2023
@cescoffier cescoffier deleted the fix-bad-JS-identifier branch January 17, 2023 12:45
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 17, 2023
@gsmet gsmet modified the milestones: 2.17 - main, 2.16.0.Final Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send button for GRPC in dev mode broken
3 participants