Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix istio CI workflow by adding --embed-certs #30406

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix istio CI workflow by adding --embed-certs #30406

merged 1 commit into from
Jan 19, 2023

Conversation

Sgitario
Copy link
Contributor

Related to #29536

@Sgitario Sgitario requested a review from gsmet January 17, 2023 06:57
@Sgitario Sgitario mentioned this pull request Jan 17, 2023
Open
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jan 17, 2023
@geoand geoand requested a review from iocanel January 17, 2023 09:48
@quarkus-bot

This comment has been minimized.

Sign in to view
iocanel
iocanel approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 19, 2023

Failing Jobs - Building a74af16

Status Name Step Failures Logs Raw logs
✔️ Maven Tests - JDK 11
⌛ Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

gsmet
gsmet approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsmet gsmet merged commit 1d30c00 into quarkusio:main Jan 19, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 19, 2023
@Sgitario Sgitario deleted the fix_istio_ci branch January 19, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Milestone
3.0.0.Alpha4
Development

Successfully merging this pull request may close these issues.
3 participants
@Sgitario @iocanel @gsmet