Support retrieval of all Multipart parts in RESTEasy Reactive #30307
Conversation
geoand
changed the title
|
@pedroigor you might be interested in this as well :) |
geoand
force-pushed
the
multipart-improvements
branch
from
f99062a to
2e56114
Compare
| @@ -11,7 +11,7 @@ | |||
| import javax.ws.rs.core.MediaType; | |||
|
|
|||
| import org.jboss.resteasy.reactive.RestResponse; | |||
| import org.jboss.resteasy.reactive.server.core.multipart.MultipartFormDataOutput; | |||
| import org.jboss.resteasy.reactive.server.multipart.MultipartFormDataOutput; | |||
There was a problem hiding this comment.
Would it be hard to keep the old class for a few versions as deprecated and then drop it? (If we can easily extend the new one and have things working.)
There was a problem hiding this comment.
I tried initially, but it turned out to be a big hassle so I opted against it (especially considering it's just a package change)
There was a problem hiding this comment.
OK, if it's too much of a hassle, I totally agree. Let's make sure we drop a line there: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.17 when merged.
|
@geoand Thanks. It seems to make the integration easier so I can drop a few code from our side. Are you backporting this change to 2.13? Or is it targeted to v3? |
|
It will be tough to backport this one (we would obviously not backport the breaking change commit), but if it's important enough, we can certainly try |
|
It is not critical and the current integration seems to work fine. We started the v3 upgrade and I should be able to merge the RR changes after KC 21 is out. |
This is similar to what RESTEasy Classic provides with
org.jboss.resteasy.plugins.providers.multipart.MultipartFormDataInput.The change is breaking because I moved the package of
MultipartFormDataOutputto the API package instead of the internal package where it was residing.The meat of the PR is the final commit.