Improves documentation on SecurityIdentityAugmentor with Hibernate #30283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanny96
force-pushed
the
main
branch
3 times, most recently
from
b9879ed to
053c38b
Compare
sberyozkin
reviewed
Jan 15, 2023
There was a problem hiding this comment.
@vanny96, thanks for the PR, @loicmathieu, can you please review it can work as expected given your earlier case ?
loicmathieu
approved these changes
Jan 16, 2023
sberyozkin
reviewed
Jan 16, 2023
vanny96
force-pushed
the
main
branch
5 times, most recently
from
3329020 to
c689a50
Compare
sberyozkin
approved these changes
Jan 23, 2023
|
@vanny96 Can you please squash the last commit ? Thanks |
gsmet
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
🙈 The PR is closed and the preview is expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example at Security Tips and Tricks for Hibernate doesn't work as it results in a ContextNotActiveException (See issue 12640).
The proper solution to use Hibernate in a SecurityIdentityAugmentor is to create a class which extends Supplier and annotate its
getmethod with@ActivateRequestContextThis MR provides this solution as the example to use in the documentation