MongoDB with Panache: allow setting per collection read preference #30118
Conversation
This comment has been minimized.
This comment has been minimized.
|
I have one question about this: What happens if the user enters an incorrect value? |
|
My guess would be that |
|
@gsmet we also do this when we build the MongoClient as we can pass the default read preference from the config. Currently, this would generate an IAE: I can try/catch and give a more meaningful message but this will still be an IAE |
|
A more meaningful / contextual message is always better :) |
loicmathieu
force-pushed
the
per-entity-read-preference
branch
from
3af5026 to
bb402b2
Compare
| try { | ||
| collection = collection.withReadPreference(ReadPreference.valueOf(mongoEntity.readPreference())); | ||
| } catch (IllegalArgumentException iae) { | ||
| throw new IllegalArgumentException("Illegal read preference " + mongoEntity.readPreference() |
There was a problem hiding this comment.
We should probably pass the original exception as the cause
There was a problem hiding this comment.
I agree this is usually a good practice but here it will not give additional information.
There was a problem hiding this comment.
Okay, if you have actually seen what it looks like, I trust you :)
| } catch (IllegalArgumentException iae) { | ||
| throw new IllegalArgumentException("Illegal read preference " + mongoEntity.readPreference() | ||
| + " configured in the @MongoEntity annotation of " + entityClass.getName() + "." | ||
| + " Supported values are primary|primaryPreferred|secondary|secondaryPreferred|nearest"); |
There was a problem hiding this comment.
Just asking: you cannot extract the values from the enum? (I haven't checked)
There was a problem hiding this comment.
No, this is not en enum but a regular class.
Failing Jobs - Building bb402b2
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 MacOS M1 #- Failing: integration-tests/mongodb-panache
📦 integration-tests/mongodb-panache✖ ✖ ✖ ✖ |
|
Weird how the M1 tests are failing on some Mongo tests... Is it related? |
Fixes #29997