Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set get action port to null in custom resources for Knative #29972

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Do not set get action port to null in custom resources for Knative #29972

merged 1 commit into from
Dec 21, 2022

Conversation

Sgitario
Copy link
Contributor

Relates #29962

@Sgitario Sgitario mentioned this pull request Dec 20, 2022
Closed
@geoand geoand requested a review from iocanel December 20, 2022 11:00
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 20, 2022

Failing Jobs - Building f41d44a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

iocanel
iocanel approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sgitario Sgitario merged commit 4e08d3a into quarkusio:main Dec 21, 2022
@Sgitario Sgitario deleted the 29921 branch December 21, 2022 09:53
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/kubernetes
Projects
None yet
Milestone
2.16.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@Sgitario @iocanel