-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
give more explicit pointer to the contribute guide #29909
Conversation
relates to #29907 |
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
This comment has been minimized.
This comment has been minimized.
Just add an additional sentence or direct link to the adoc file that is in the same directory... The pretty version is rendered on the web.. but the adoc is perfectly readable and is right there... |
which adoc file? the docs folder has no such file. |
See the suggested edits. All of those files exist in docs/src/asciidoc. |
ok, so not the same folder. |
push update that points out the nested readme.adoc to avoid duplication and broken links. |
squash please. |
@maxandersen thank you for the update. I spotted some typos and dropped in edit suggestions to fix. Other than that, LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some phrasing suggestions, too. Feel free to accept/decline them as you see fit, but please fix the typos:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squashed and tuned some additional things.
I would prefer the relevant
mvn
commands to use/run was documented in the repo rather than "off-site" but with this there is at least a chance to discover the documentation.