Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to ad-m/github-push-action #29856

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Remove calls to ad-m/github-push-action #29856

merged 1 commit into from
Dec 15, 2022

Conversation

gastaldi
Copy link
Contributor

  • No need to call it again as tags are already pushed in the previous call

@gastaldi gastaldi requested review from geoand and gsmet December 14, 2022 13:13
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Dec 14, 2022
@gastaldi gastaldi marked this pull request as draft December 14, 2022 15:33
@gastaldi
Copy link
Contributor Author

Marking as a draft until I test it properly

gsmet
gsmet reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a question about a weird change.

...n/resources/codestarts/quarkus-extension/code/quarkiverse/java/.github/workflows/release.yml Show resolved Hide resolved
...n/resources/codestarts/quarkus-extension/code/quarkiverse/java/.github/workflows/release.yml Outdated Show resolved Hide resolved
@gastaldi
Remove calls to ad-m/github-push-action
9459251 
Remove -DpreparationGoals
@gastaldi gastaldi marked this pull request as ready for review December 15, 2022 11:00
@gastaldi gastaldi requested a review from gsmet December 15, 2022 11:03
@gastaldi gastaldi changed the title Remove extra call to ad-m/github-push-action Remove calls to ad-m/github-push-action Dec 15, 2022
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 15, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 15, 2022

Failing Jobs - Building 9459251

Status Name Step Failures Logs Raw logs
⌛ Native Tests - Data6 Build ⚠️ Check → Logs Raw logs

@gastaldi gastaldi merged commit b0d399d into quarkusio:main Dec 15, 2022
@gastaldi gastaldi deleted the remove_push_tags branch December 15, 2022 16:03
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 15, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 15, 2022
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.15.1.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@gastaldi @gsmet