Fix PostgreSQL XA mode in native images #29787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imperatorx
changed the title
gsmet
approved these changes
Dec 13, 2022
| @@ -19,6 +19,9 @@ void build(BuildProducer<ReflectiveClassBuildItem> reflectiveClass) { | |||
| //We register it for the sake of other users. | |||
| final String driverName = "org.postgresql.Driver"; | |||
| reflectiveClass.produce(new ReflectiveClassBuildItem(false, false, driverName)); | |||
|
|
|||
| // Needed when quarkus.datasource.jdbc.transactions=xa for the setting of the username and password | |||
| reflectiveClass.produce(new ReflectiveClassBuildItem(false, true, false, "org.postgresql.ds.common.BaseDataSource")); | |||
There was a problem hiding this comment.
I wonder if we should have a better infrastructure to push the classes to the JDBC build item and get the JDBC infrastructure do the work. But maybe let's wait to have another similar case before doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using XA transactions in native images with PostgreSQL, an additional reflective items needs to be registered, otherwise the setUser() and setPassword() on the XA datasource is not recognized, and quarkus cannot connect to postgres.
Reproduce:
quarkus.datasource.jdbc.transactions=xaand generate a native image, use postgres with standard password authentication, application will fail to connect as username and password are missing from the connect.When this is not set to XA, the bug is not occuring, as the XA datasource is not used.