Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install mock by TypeLiteral and Qualifiers #29779

Merged

Conversation

gonciarz
Copy link
Contributor

@gonciarz gonciarz commented Dec 9, 2022

No description provided.

@geoand
Copy link
Contributor

geoand commented Dec 12, 2022

Thanks for this!

We'll need this to rebased onto main in order to get rid of the merge commit

@geoand
Copy link
Contributor

geoand commented Jan 10, 2023

@gonciarz would you like to rebase this onto main?

@gsmet gsmet force-pushed the install_mock_by_typeliteral_and_qualifiers branch from 62323ee to c80a3c6 Compare January 30, 2023 16:36
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned up the commits. It should be good to go now. Thanks!

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 30, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 30, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit 26ba575 into quarkusio:main Jan 31, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 31, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants