-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config editor when using HTTPS #29586
Conversation
Fixes quarkusio#29431 This is a workaround though. The core of the problem is that when in HTTPS, event.request().absoluteURI() returns an HTTP url, which is wrong and leads to the redirect not working.
Failing Jobs - Building e2572f4
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/kafka-sasl
📦 integration-tests/kafka-sasl✖
|
@gsmet Can you open an issue about the "event.request().absoluteURI() returns an HTTP url, which is wrong and leads to the redirect not working." It's definitely a bug. The Vert.x logic is handling HTTPS correctly: static String absoluteURI(String serverOrigin, HttpServerRequest req) throws URISyntaxException {
String absoluteURI;
URI uri = new URI(req.uri());
String scheme = uri.getScheme();
if (scheme != null && (scheme.equals("http") || scheme.equals("https"))) {
absoluteURI = uri.toString();
} else {
String host = req.host();
if (host != null) {
absoluteURI = req.scheme() + "://" + host + uri;
} else {
// Fall back to the server origin
absoluteURI = serverOrigin + uri;
}
}
return absoluteURI;
} However, in the |
I created #29612 . |
Fixes #29431
This is a workaround though. The core of the problem is that when in HTTPS, event.request().absoluteURI() returns an HTTP url, which is wrong and leads to the redirect not working.
/cc @cescoffier