Expose configuration for quartz scheduler performance tuning #29395

fikrutm · 2022-11-21T23:47:38Z

Allows to configure maxBatchSize and batchTimeWindow to leverage the batch mode as described in #29319 .
@machi1990

machi1990 · 2022-11-22T07:43:46Z

Can you sort out the commits and remove the second merge commit? That's the reason why CI is failing. Thanks.

machi1990 · 2022-11-22T07:55:25Z

extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzRuntimeConfig.java

@@ -19,6 +19,17 @@ public class QuartzRuntimeConfig {
    @ConfigItem(defaultValue = "QuarkusQuartzScheduler")
    public String instanceName;

+    /**


Let's also allow configuring acquireTriggersWithinLock. This config item has to default to true?

This property has to be if JDBC JobStore is used i.e anywhere here

quarkus/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzSchedulerImpl.java

Lines 577 to 587 in 19bded9

String dataSource = buildTimeConfig.dataSourceName.orElse("QUARKUS_QUARTZ_DEFAULT_DATASOURCE");

QuarkusQuartzConnectionPoolProvider.setDataSourceName(dataSource);

props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".useProperties", "true");

props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".misfireThreshold",

"" + quartzSupport.getRuntimeConfig().misfireThreshold.toMillis());

props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".tablePrefix", buildTimeConfig.tablePrefix);

props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".dataSource", dataSource);

props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".driverDelegateClass",

quartzSupport.getDriverDialect().get());

props.put(StdSchedulerFactory.PROP_DATASOURCE_PREFIX + "." + dataSource + ".connectionProvider.class",

QuarkusQuartzConnectionPoolProvider.class.getName());

Yes the acquireTriggersWithinLock has to be true if JDBC JobStore is used, but the default value is either false or true. As of Quartz 2.1.1 “true is the default if batchTriggerAquisitionMaxCount is set to >1 otherwise false by defualt.

machi1990

see the comments

machi1990

Added one comment

Can you also squash the commit before we merge this one? Thanks

extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzSchedulerImpl.java

…hTriggerAcquisitionMaxCount and set acquireTriggersWithinLock to true for JDBC JobStore

machi1990

Thanks @fikrutm

machi1990 · 2022-11-28T07:39:33Z

@mkouba can you've a look as well?

mkouba

Looks good. I assume that there is no easy way to test those config properties, right?

geoand · 2022-11-28T11:54:41Z

extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzRuntimeConfig.java

+     * The amount of time in milliseconds that a trigger is allowed to be acquired and fired ahead of its scheduled fire time.
+     */
+    @ConfigItem(defaultValue = "0")
+    public long batchTriggerAcquisitionFireAheadTimeWindow;


Wouldnt't it be better for users and also more consistent with the rest of the properties if this where a Duration?

It depends. I think that it's kind of reasonable to follow the way Quartz defines the property, i.e. "the amount of time in milliseconds" so that users can just copy and paste properties from the quartz config file. OTOH Duration is indeed an idiomatic way in Quarkus.

Duration is also used here.

Duration is also used here.

Yes, but this config property is not passed directly to quartz. It's a quarkus-quartz -specific property.

Sure, but it creates a suboptimal user experience to not be consistent

Sure, but it creates a suboptimal user experience to not be consistent

To be fair, I think someone wanting to configure this will be pretty much experienced with quartz so they may want to just use the config value they are already used to.

Yeah, I understand. I'll leave this up to you guys

I'm not sure. This config property will be very likely set by advanced users who seek consistency with Quartz. Just my 2c. That said, I don't have a problem with Duration.

quarkus-bot bot added the area/scheduler label Nov 21, 2022

machi1990 reviewed Nov 22, 2022

View reviewed changes

machi1990 requested changes Nov 22, 2022

View reviewed changes

fikrutm force-pushed the main branch from 19bded9 to 9b61473 Compare November 22, 2022 20:00

machi1990 requested changes Nov 23, 2022

View reviewed changes

extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzSchedulerImpl.java Outdated Show resolved Hide resolved

machi1990 requested a review from mkouba November 23, 2022 11:49

Allow configuring batchTriggerAcquisitionFireAheadTimeWindow and batc…

76e703f

…hTriggerAcquisitionMaxCount and set acquireTriggersWithinLock to true for JDBC JobStore

fikrutm force-pushed the main branch from 88bfa7e to 76e703f Compare November 23, 2022 23:27

machi1990 approved these changes Nov 28, 2022

View reviewed changes

mkouba approved these changes Nov 28, 2022

View reviewed changes

machi1990 added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 28, 2022

machi1990 requested review from gsmet and geoand November 28, 2022 11:45

geoand reviewed Nov 28, 2022

View reviewed changes

geoand removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 28, 2022

machi1990 merged commit b82d50f into quarkusio:main Dec 2, 2022

quarkus-bot bot added this to the 2.16 - main milestone Dec 2, 2022

machi1990 mentioned this pull request May 23, 2023

Expose Quartz underlying configuration in Quarkus/quartz for perfomance tuning #29319

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose configuration for quartz scheduler performance tuning #29395

Expose configuration for quartz scheduler performance tuning #29395

fikrutm commented Nov 21, 2022

machi1990 commented Nov 22, 2022 •

edited

Loading

machi1990 Nov 22, 2022

fikrutm Nov 22, 2022

machi1990 left a comment

machi1990 left a comment

machi1990 left a comment

machi1990 commented Nov 28, 2022

mkouba left a comment •

edited

Loading

geoand Nov 28, 2022

mkouba Nov 28, 2022

geoand Nov 28, 2022

mkouba Nov 28, 2022

geoand Nov 28, 2022

machi1990 Nov 28, 2022

geoand Nov 28, 2022 •

edited

Loading

mkouba Nov 28, 2022

	String dataSource = buildTimeConfig.dataSourceName.orElse("QUARKUS_QUARTZ_DEFAULT_DATASOURCE");
	QuarkusQuartzConnectionPoolProvider.setDataSourceName(dataSource);
	props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".useProperties", "true");
	props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".misfireThreshold",
	"" + quartzSupport.getRuntimeConfig().misfireThreshold.toMillis());
	props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".tablePrefix", buildTimeConfig.tablePrefix);
	props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".dataSource", dataSource);
	props.put(StdSchedulerFactory.PROP_JOB_STORE_PREFIX + ".driverDelegateClass",
	quartzSupport.getDriverDialect().get());
	props.put(StdSchedulerFactory.PROP_DATASOURCE_PREFIX + "." + dataSource + ".connectionProvider.class",
	QuarkusQuartzConnectionPoolProvider.class.getName());

Expose configuration for quartz scheduler performance tuning #29395

Expose configuration for quartz scheduler performance tuning #29395

Conversation

fikrutm commented Nov 21, 2022

machi1990 commented Nov 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

machi1990 left a comment

Choose a reason for hiding this comment

machi1990 left a comment

Choose a reason for hiding this comment

machi1990 left a comment

Choose a reason for hiding this comment

machi1990 commented Nov 28, 2022

mkouba left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geoand Nov 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

machi1990 commented Nov 22, 2022 •

edited

Loading

mkouba left a comment •

edited

Loading

geoand Nov 28, 2022 •

edited

Loading