Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDI decorators - fix processing of decorated methods #29386

Merged
merged 1 commit into from
Nov 23, 2022
Merged

CDI decorators - fix processing of decorated methods #29386

merged 1 commit into from
Nov 23, 2022
+110 −20

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 21, 2022

@mkouba mkouba requested review from Ladicek and manovotn November 21, 2022 16:39
@quarkus-bot

This comment has been minimized.

Sign in to view
Ladicek
Ladicek approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I confess I didn't investigate very deep :-)

@mkouba mkouba added area/arc Issue related to ARC (dependency injection) triage/backport? labels Nov 22, 2022
@mkouba
Copy link
Contributor Author

mkouba commented Nov 22, 2022

Looks good, but I confess I didn't investigate very deep :-)

No problem, it's not exactly a fun topic ;-).

manovotn
manovotn approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@manovotn manovotn merged commit 42ed83c into quarkusio:main Nov 23, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 23, 2022
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.2.Final Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
Milestone
2.14.2.Final
Development

Successfully merging this pull request may close these issues.

Failing to create decorator bean on interface with overloaded methods
4 participants
@mkouba @Ladicek @manovotn @gsmet