Bump to Vert.x 4.8.5

[geoand]

This is still WIP since I have currently only run the HTTP tests in JVM mode.

The HTTP2 test that was disabled in the second commit seems to be hanging completely.

cc @vietj @cescoffier @franz1981

[geoand]

This will also need some work on the native side of things as I am getting:

com.oracle.graal.pointsto.constraints.UnresolvedElementException: Discovered unresolved type during parsing: io.netty.handler.codec.http.HttpHeaderValidationUtil. This error is reported at image build time because class io.vertx.core.http.impl.Http1xUpgradeToH2CHandler is registered for linking at image build time by command line

[geoand]

The previous comment no longer applies after updating Quarkus to Netty 4.1.85

[geoand]

I have not executed all the tests, but the ones I have all pass (JVM and native).

[cescoffier]

@geoand I will start the release train (only the bindings) tomorrow morning, then, we need to update this PR and remove "draft"

[geoand]

Cool

[cescoffier]

@geoand Just pushed a commit; we would need to rebase and squash.

If the CI is green, I think it's good to go.

[geoand]

Sure thing, I'll do that tomorrow morning

[geoand]

@cescoffier it should be good to go

[geoand]

Also cc @Sanne @franz1981 who I know are waiting on this :)

[geoand]

Seems like Http2ServerPushTestCase.testServerPush is failing, which means that we need to update Quarkus HTTP?

[cescoffier]

The HTTP/2 server push looks related.
It might be because of: eclipse-vertx/vert.x@0de1c53

\CC @vietj

[cescoffier]

Hold on... me stupid: the error is:

2022-11-21 10:46:12,458 ERROR [io.qua.ver.cor.run.VertxCoreRecorder] (vert.x-eventloop-thread-0) Uncaught exception received by Vert.x: java.lang.IncompatibleClassChangeError: class io.undertow.vertx.PushedHttpServerRequest can not implement io.vertx.core.http.impl.HttpServerRequestInternal, because it is not an interface (io.vertx.core.http.impl.HttpServerRequestInternal is in unnamed module of loader io.quarkus.bootstrap.clas

[cescoffier]

We need to update and release quarkus-http.

[geoand]

Are you going to handle that or should I?

[cescoffier]

Well, the update is not going well. When I update to Vert.x 4.3.5, things are blowing up.

[geoand]

Ouch...

[cescoffier]

Let's see how it goes: quarkusio/quarkus-http#108.

I can't build locally, but let's see what the CI has to say (my local build was working with the old Vert.x version)

[cescoffier]

So, quarkus-http "fixed" and release on its way to Maven central (4.2.1)

[geoand]

🎉

[gsmet]

You will also need to update to 5.0.0.Alpha3 here: https://github.com/quarkusio/quarkus/blob/main/jakarta/rewrite.yml#L133-L135

[cescoffier]

@gsmet do you manage the second Quarkus HTTP release (5.x?)

[gsmet]

@cescoffier yes, already done, see my comment above ^^

[cescoffier]

Sorry, had some calls; I've updated the Quarkus HTTP versions.

[Sanne]

that's great, thanks all :)
@geoand , @franz1981 is this including any of the patches we were waiting for in relation to super type caches?

[geoand]

Yes, it contains some Vert.x updates in that respect

[geoand]

Fixed the conflict so this should be good to go when CI passes

[gsmet]

Be careful, CI has not started somehow and the status is green while CI still has to run.

[gsmet]

(My guess is that we have too many things running)

[Sanne]

cool, looks like it's actually running now - and looking good so far :)

[geoand]

Everything is green and CI did actually run, so I'll merge thks