Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IsDockerWorking class not using TestContainersStrategy #29201

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Fix IsDockerWorking class not using TestContainersStrategy #29201

merged 1 commit into from
Nov 12, 2022

Conversation

jorsol
Copy link
Contributor

@jorsol jorsol commented Nov 11, 2022

Fixes #29188

@jorsol jorsol mentioned this pull request Nov 11, 2022
Closed
geoand
geoand reviewed Nov 11, 2022
View reviewed changes
core/deployment/src/main/java/io/quarkus/deployment/IsDockerWorking.java
@@ -84,7 +84,7 @@ public Result get() {

Class<?> configurationClass = Thread.currentThread().getContextClassLoader()
.loadClass("org.testcontainers.utility.TestcontainersConfiguration");
Object configurationInstance = configurationClass.getMethod("instance").invoke(null);
Object configurationInstance = configurationClass.getMethod("getInstance").invoke(null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

geoand
geoand approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Nov 11, 2022
@jorsol
Copy link
Contributor Author

jorsol commented Nov 11, 2022

What about also triage/backport-2.13? since it affects that version too?

@geoand
Copy link
Contributor

geoand commented Nov 11, 2022

It does? Are you sure?

@jorsol
Copy link
Contributor Author

jorsol commented Nov 11, 2022 •
edited
Loading

It does? Are you sure?

Yes, I'm sure, it was introduced in 2.13.4.Final, that's where I caught this: #28702

@geoand
Copy link
Contributor

geoand commented Nov 11, 2022

Okay, thanks for checking

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 12, 2022

Failing Jobs - Building eac0e5e

Status Name Step Failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
⌛ JVM Tests - JDK 17 MacOS M1 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/micrometer/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/quartz/deployment extensions/scheduler/deployment and 21 more

📦 extensions/micrometer/deployment

✖ io.quarkus.micrometer.deployment.binder.HttpDevModeConfigTest.test line 90 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/grpc/runtime 
! Skipped: extensions/grpc/deployment extensions/micrometer-registry-prometheus/deployment extensions/micrometer-registry-prometheus/runtime and 43 more

📦 extensions/grpc/runtime

✖ io.quarkus.grpc.runtime.supports.BlockingServerInterceptorTest.testContextPropagation line 70 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "my-user"

@geoand geoand merged commit 967d349 into quarkusio:main Nov 12, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 12, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 12, 2022
@jorsol jorsol deleted the 29188-IsDockerWorking branch November 12, 2022 18:48
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.1.Final Nov 15, 2022
@gsmet gsmet modified the milestones: 2.14.1.Final, 2.13.6.Final Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core kind/bugfix triage/flaky-test
Projects
None yet
Milestone
2.13.6.Final
Development

Successfully merging this pull request may close these issues.

IsDockerWorking not using TestContainersStrategy after 2.13.4.Final
3 participants
@jorsol @geoand @gsmet