Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table entries in documentation #29102

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix table entries in documentation #29102

merged 1 commit into from
Nov 9, 2022

Conversation

mercur3
Copy link
Contributor

@mercur3 mercur3 commented Nov 7, 2022

In the current state the description for /api/user/me endpoint corresponds to /api/admin and vice versa.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create a pull request. I added a small suggestion.

| `/api/admin`| The `/api/admin` endpoint is protected with role-based access control (RBAC), and only users who have been granted the `admin` role can access it.
At this endpoint, the `@RolesAllowed` annotation is used to declaratively enforce the access constraint.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put this entry first given it arrives first in the doc?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted it. Let's wait for CI and merge.

@mercur3
Copy link
Contributor Author

mercur3 commented Nov 8, 2022

Thanks, I was using the work device so I couldn't do it right away.

@gsmet gsmet merged commit 38acaed into quarkusio:main Nov 9, 2022
@gsmet
Copy link
Member

gsmet commented Nov 9, 2022

Thanks!

@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 9, 2022
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.1.Final Nov 10, 2022
@gsmet gsmet modified the milestones: 2.14.1.Final, 2.13.6.Final Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants