-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that Mandrel 22.3 does not provide a -java11 image anymore #29087
Conversation
Fix graalvm/mandrel#456. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @cescoffier , I have added a couple of recommendations for your consideration.
I think at least the formatting ones (along with @gsmet 's suggestions) should be integrated.
@cescoffier could you have a look at our suggestions? Thanks. |
87be45d
to
808af60
Compare
@gsmet done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just added another suggestion you might want to consider.
b38ef85
to
2c363d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied @zakkak 's suggestion and squashed. It's ready to go.
No description provided.