Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When propagating the duplicated context, drop the request scope #29036

Conversation

cescoffier
Copy link
Member

Fix #29017

@cescoffier cescoffier requested a review from mkouba November 3, 2022 13:07
@cescoffier cescoffier changed the title When propagating the duplicated context, drop the request scope. When propagating the duplicated context, drop the request scope Nov 3, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 3, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@mkouba
Copy link
Contributor

mkouba commented Nov 3, 2022

I can confirm that this pull request fixed the problem mentioned in #29017.

@mkouba mkouba requested a review from gsmet November 3, 2022 16:30
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 3, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 3, 2022

Failing Jobs - Building 4293f37

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@geoand geoand merged commit 1e8931e into quarkusio:main Nov 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 4, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 4, 2022
@cescoffier cescoffier deleted the an-attempt-to-avoid-concurrent-request-scope-access branch November 4, 2022 07:25
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.1.Final Nov 5, 2022
@mkouba
Copy link
Contributor

mkouba commented Nov 15, 2022

Should we backport this into 2.13?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request Context Race condition in quarkus 2.13
4 participants