-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When propagating the duplicated context, drop the request scope #29036
Merged
geoand
merged 2 commits into
quarkusio:main
from
cescoffier:an-attempt-to-avoid-concurrent-request-scope-access
Nov 4, 2022
Merged
When propagating the duplicated context, drop the request scope #29036
geoand
merged 2 commits into
quarkusio:main
from
cescoffier:an-attempt-to-avoid-concurrent-request-scope-access
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
changed the title
When propagating the duplicated context, drop the request scope.
When propagating the duplicated context, drop the request scope
Nov 3, 2022
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
gsmet
reviewed
Nov 3, 2022
extensions/vertx/runtime/src/main/java/io/quarkus/vertx/core/runtime/VertxCoreRecorder.java
Outdated
Show resolved
Hide resolved
I can confirm that this pull request fixed the problem mentioned in #29017. |
mkouba
approved these changes
Nov 3, 2022
mkouba
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Nov 3, 2022
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Ready to merge when CI successfully finishes
labels
Nov 4, 2022
cescoffier
deleted the
an-attempt-to-avoid-concurrent-request-scope-access
branch
November 4, 2022 07:25
Should we backport this into 2.13? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29017